netdev - Re: [PATCH bpf-next v2 2/3] net: move struct netdev_rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bd6c0dee-3f2c-3613-a5ff-42cc11268e49@kernel.org>
Date: Thu, 3 Aug 2023 16:24:26 +0200
From: Jesper Dangaard Brouer <hawk@...nel.org>
To: Jakub Kicinski <kuba@...nel.org>
Cc: netdev@...r.kernel.org, bpf@...r.kernel.org, amritha.nambiar@...el.com,
 aleksander.lobakin@...el.com, mst@...hat.com, jasowang@...hat.com,
 xuanzhuo@...ux.alibaba.com, ast@...nel.org, daniel@...earbox.net,
 andrii@...nel.org, martin.lau@...ux.dev, song@...nel.org,
 yonghong.song@...ux.dev, john.fastabend@...il.com, kpsingh@...nel.org,
 sdf@...gle.com, haoluo@...gle.com, jolsa@...nel.org, bjorn@...nel.org,
 magnus.karlsson@...el.com, maciej.fijalkowski@...el.com,
 jonathan.lemon@...il.com, gregkh@...uxfoundation.org, wangyufen@...wei.com,
 virtualization@...ts.linux-foundation.org
Subject: Re: [PATCH bpf-next v2 2/3] net: move struct netdev_rx_queue out of
 netdevice.h



On 03/08/2023 03.02, Jakub Kicinski wrote:
> struct netdev_rx_queue is touched in only a few places
> and having it defined in netdevice.h brings in the dependency
> on xdp.h, because struct xdp_rxq_info gets embedded in
> struct netdev_rx_queue.
> 
> In prep for removal of xdp.h from netdevice.h move all
> the netdev_rx_queue stuff to a new header.
> 
> We could technically break the new header up to avoid
> the sysfs.h include but it's so rarely included it
> doesn't seem to be worth it at this point.
> 
> Reviewed-by: Amritha Nambiar<amritha.nambiar@...el.com>
> Signed-off-by: Jakub Kicinski<kuba@...nel.org>
> ---

Acked-by: Jesper Dangaard Brouer <hawk@...nel.org>