netdev - Re: [PATCH bpf-next v2 2/3] net: move struct netdev_rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b67d4e91-9802-57f1-462a-38000a6e159f@intel.com>
Date: Thu, 3 Aug 2023 17:52:32 +0200
From: Alexander Lobakin <aleksander.lobakin@...el.com>
To: Jakub Kicinski <kuba@...nel.org>
CC: <ast@...nel.org>, <netdev@...r.kernel.org>, <bpf@...r.kernel.org>,
	<hawk@...nel.org>, <amritha.nambiar@...el.com>, <mst@...hat.com>,
	<jasowang@...hat.com>, <xuanzhuo@...ux.alibaba.com>, <daniel@...earbox.net>,
	<andrii@...nel.org>, <martin.lau@...ux.dev>, <song@...nel.org>,
	<yonghong.song@...ux.dev>, <john.fastabend@...il.com>, <kpsingh@...nel.org>,
	<sdf@...gle.com>, <haoluo@...gle.com>, <jolsa@...nel.org>,
	<bjorn@...nel.org>, <magnus.karlsson@...el.com>,
	<maciej.fijalkowski@...el.com>, <jonathan.lemon@...il.com>,
	<gregkh@...uxfoundation.org>, <wangyufen@...wei.com>,
	<virtualization@...ts.linux-foundation.org>
Subject: Re: [PATCH bpf-next v2 2/3] net: move struct netdev_rx_queue out of
 netdevice.h

From: Jakub Kicinski <kuba@...nel.org>
Date: Wed,  2 Aug 2023 18:02:29 -0700

> struct netdev_rx_queue is touched in only a few places
> and having it defined in netdevice.h brings in the dependency
> on xdp.h, because struct xdp_rxq_info gets embedded in
> struct netdev_rx_queue.

[...]

> +static inline struct netdev_rx_queue *
> +__netif_get_rx_queue(struct net_device *dev, unsigned int rxq)
> +{
> +	return dev->_rx + rxq;
> +}
> +
> +#ifdef CONFIG_SYSFS
> +static inline unsigned int
> +get_netdev_rx_queue_index(struct netdev_rx_queue *queue)
> +{
> +	struct net_device *dev = queue->dev;
> +	int index = queue - dev->_rx;
> +
> +	BUG_ON(index >= dev->num_rx_queues);
> +	return index;
> +}
> +#endif
> +#endif

Looks a bit confusing :s Could you separate then by a NL and leave a
comment near each one with the corresponding definition? Like

	return index;
}
#endif /* CONFIG_SYSFS */

#endif /* _LINUX_NETDEV_RX_QUEUE_H */

Maybe Alex could do that when applying, given that there are no more
change requests.

> diff --git a/net/bpf/test_run.c b/net/bpf/test_run.c
> index 7d47f53f20c1..0aac76c13fd4 100644
> --- a/net/bpf/test_run.c
> +++ b/net/bpf/test_run.c
> @@ -20,6 +20,7 @@

[...]

Thanks,
Olek