netdev - RE: [PATCH v3 00/16] stmmac: Add Loongson platform support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 4 Aug 2023 17:25:54 +0000
From: Jose Abreu <Jose.Abreu@...opsys.com>
To: Feiyang Chen <chenfeiyang@...ngson.cn>, "andrew@...n.ch" <andrew@...n.ch>,
        "hkallweit1@...il.com" <hkallweit1@...il.com>,
        "peppe.cavallaro@...com"
	<peppe.cavallaro@...com>,
        "alexandre.torgue@...s.st.com"
	<alexandre.torgue@...s.st.com>,
        "chenhuacai@...ngson.cn"
	<chenhuacai@...ngson.cn>
CC: "linux@...linux.org.uk" <linux@...linux.org.uk>,
        "dongbiao@...ngson.cn" <dongbiao@...ngson.cn>,
        "loongson-kernel@...ts.loongnix.cn" <loongson-kernel@...ts.loongnix.cn>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "loongarch@...ts.linux.dev" <loongarch@...ts.linux.dev>,
        "chris.chenfeiyang@...il.com" <chris.chenfeiyang@...il.com>,
        Jose Abreu <Jose.Abreu@...opsys.com>
Subject: RE: [PATCH v3 00/16] stmmac: Add Loongson platform support

From: Feiyang Chen <chenfeiyang@...ngson.cn>
Date: Thu, Aug 03, 2023 at 12:28:02

> Extend stmmac functions and macros for Loongson DWMAC.
> Add LS7A support for dwmac_loongson.
> 
> v2 -> v3:
> * Avoid macros accessing variables that are not passed to them.
> * Implement a new struct to support 64-bit DMA.
> * Use feature names rather than 'lgmac' and 'dwmac_is_loongson'.

This is still mixing up with HWIF.

As I tried to highlight before, if you are using a custom IP,
you need custom callbacks. 

As far as I saw, you are mixing dwmac1000_core with
Loongson registers, which is not what I believe is the best approach.

I understand that stmmac is confusing and needs a lot of revamp.
Perhaps we can switch to regmaps first? This way you would have
a lot more flexibility.

Thanks,
Jose