lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Fri, 4 Aug 2023 17:28:49 +0000
From: Jose Abreu <Jose.Abreu@...opsys.com>
To: Feiyang Chen <chenfeiyang@...ngson.cn>, "andrew@...n.ch" <andrew@...n.ch>,
        "hkallweit1@...il.com" <hkallweit1@...il.com>,
        "peppe.cavallaro@...com"
	<peppe.cavallaro@...com>,
        "alexandre.torgue@...s.st.com"
	<alexandre.torgue@...s.st.com>,
        "chenhuacai@...ngson.cn"
	<chenhuacai@...ngson.cn>
CC: "linux@...linux.org.uk" <linux@...linux.org.uk>,
        "dongbiao@...ngson.cn" <dongbiao@...ngson.cn>,
        "loongson-kernel@...ts.loongnix.cn" <loongson-kernel@...ts.loongnix.cn>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "loongarch@...ts.linux.dev" <loongarch@...ts.linux.dev>,
        "chris.chenfeiyang@...il.com" <chris.chenfeiyang@...il.com>,
        Jose Abreu <Jose.Abreu@...opsys.com>
Subject: RE: [PATCH v3 14/16] net: stmmac: dwmac-loongson: Disable flow
 control for GMAC

From: Feiyang Chen <chenfeiyang@...ngson.cn>
Date: Thu, Aug 03, 2023 at 12:30:35

> --- a/include/linux/stmmac.h
> +++ b/include/linux/stmmac.h
> @@ -360,5 +360,6 @@ struct plat_stmmacenet_data {
>  	bool dma_reset_times;
>  	u32 control_value;
>  	u32 irq_flags;
> +	bool disable_flow_control;
>  };
>  #endif

This (and other patches of this series) use a bool flag instead of the
Recently added bitfield flags, can you please switch to the bitfield flags?

Thanks,
Jose

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ