netdev - Re: [PATCH v3 14/16] net: stmmac: dwmac-loongson: Disable flow control for GMAC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Sat, 5 Aug 2023 14:15:05 +0800
From: Feiyang Chen <chris.chenfeiyang@...il.com>
To: Jose Abreu <Jose.Abreu@...opsys.com>
Cc: Feiyang Chen <chenfeiyang@...ngson.cn>, "andrew@...n.ch" <andrew@...n.ch>, 
	"hkallweit1@...il.com" <hkallweit1@...il.com>, "peppe.cavallaro@...com" <peppe.cavallaro@...com>, 
	"alexandre.torgue@...s.st.com" <alexandre.torgue@...s.st.com>, 
	"chenhuacai@...ngson.cn" <chenhuacai@...ngson.cn>, "linux@...linux.org.uk" <linux@...linux.org.uk>, 
	"dongbiao@...ngson.cn" <dongbiao@...ngson.cn>, 
	"loongson-kernel@...ts.loongnix.cn" <loongson-kernel@...ts.loongnix.cn>, 
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>, 
	"loongarch@...ts.linux.dev" <loongarch@...ts.linux.dev>
Subject: Re: [PATCH v3 14/16] net: stmmac: dwmac-loongson: Disable flow
 control for GMAC

On Sat, Aug 5, 2023 at 1:29 AM Jose Abreu <Jose.Abreu@...opsys.com> wrote:
>
> From: Feiyang Chen <chenfeiyang@...ngson.cn>
> Date: Thu, Aug 03, 2023 at 12:30:35
>
> > --- a/include/linux/stmmac.h
> > +++ b/include/linux/stmmac.h
> > @@ -360,5 +360,6 @@ struct plat_stmmacenet_data {
> >       bool dma_reset_times;
> >       u32 control_value;
> >       u32 irq_flags;
> > +     bool disable_flow_control;
> >  };
> >  #endif
>
> This (and other patches of this series) use a bool flag instead of the
> Recently added bitfield flags, can you please switch to the bitfield flags?
>

Hi, Jose,

OK.

Thanks,
Feiyang

> Thanks,
> Jose