netdev - Re: [PATCH v3 14/16] net: stmmac: dwmac-loongson: Disable flow control for GMAC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACWXhKnK+iJgmXacvOjBcxn_283n4_e-7jfnZEJD1HKaJxrPvw@mail.gmail.com>
Date: Sat, 5 Aug 2023 14:15:51 +0800
From: Feiyang Chen <chris.chenfeiyang@...il.com>
To: "Russell King (Oracle)" <linux@...linux.org.uk>
Cc: Feiyang Chen <chenfeiyang@...ngson.cn>, andrew@...n.ch, hkallweit1@...il.com, 
	peppe.cavallaro@...com, alexandre.torgue@...s.st.com, joabreu@...opsys.com, 
	chenhuacai@...ngson.cn, dongbiao@...ngson.cn, 
	loongson-kernel@...ts.loongnix.cn, netdev@...r.kernel.org, 
	loongarch@...ts.linux.dev
Subject: Re: [PATCH v3 14/16] net: stmmac: dwmac-loongson: Disable flow
 control for GMAC

On Sat, Aug 5, 2023 at 4:38 AM Russell King (Oracle)
<linux@...linux.org.uk> wrote:
>
> On Thu, Aug 03, 2023 at 07:30:35PM +0800, Feiyang Chen wrote:
> > +
> > +             if (priv->plat->disable_flow_control) {
> > +                     phy_support_sym_pause(dev->phydev);
> > +                     phy_set_sym_pause(dev->phydev, false, false, true);
> > +             }
>
> Given that stmmac uses phylink, control over the PHY is given over to
> phylink to manage on the driver's behalf. Therefore, the above is not
> very useful.
>
> The correct way to deal with this is via
>         priv->phylink_config.mac_capabilities
>
> in stmmac_phy_setup().

Hi, Russell,

OK.

Thanks,
Feiyang

>
> Thanks.
>
> --
> RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
> FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!