netdev - Re: [PATCH net-next] team: remove unreferenced header in activebackup/broadcast/roundrobin files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZM43D2GuL7lU0k4X@vergenet.net>
Date: Sat, 5 Aug 2023 13:48:31 +0200
From: Simon Horman <horms@...nel.org>
To: Zhengchao Shao <shaozhengchao@...wei.com>
Cc: netdev@...r.kernel.org, davem@...emloft.net, edumazet@...gle.com,
	kuba@...nel.org, pabeni@...hat.com, jiri@...nulli.us,
	weiyongjun1@...wei.com, yuehaibing@...wei.com
Subject: Re: [PATCH net-next] team: remove unreferenced header in
 activebackup/broadcast/roundrobin files

On Fri, Aug 04, 2023 at 07:30:35PM +0800, Zhengchao Shao wrote:
> Because linux/errno.h is unreferenced in activebackup/broadcast/roundrobin
> files, so remove it.
> 
> Signed-off-by: Zhengchao Shao <shaozhengchao@...wei.com>
> ---
>  drivers/net/team/team_mode_activebackup.c | 1 -
>  drivers/net/team/team_mode_broadcast.c    | 1 -
>  drivers/net/team/team_mode_roundrobin.c   | 1 -
>  3 files changed, 3 deletions(-)
> 
> diff --git a/drivers/net/team/team_mode_activebackup.c b/drivers/net/team/team_mode_activebackup.c
> index e0f599e2a51d..419b9083515e 100644
> --- a/drivers/net/team/team_mode_activebackup.c
> +++ b/drivers/net/team/team_mode_activebackup.c
> @@ -8,7 +8,6 @@
>  #include <linux/types.h>
>  #include <linux/module.h>
>  #include <linux/init.h>
> -#include <linux/errno.h>
>  #include <linux/netdevice.h>
>  #include <net/rtnetlink.h>
>  #include <linux/if_team.h>

Hi Zhengchao Shao,

Removing the inclusion of errno.h from team_mode_activebackup.c doesn't
seem right to me, ENOENT is used in that file.

The other two below seem fine to me.

> diff --git a/drivers/net/team/team_mode_broadcast.c b/drivers/net/team/team_mode_broadcast.c
> index 313a3e2d68bf..61d7d79f0c36 100644
> --- a/drivers/net/team/team_mode_broadcast.c
> +++ b/drivers/net/team/team_mode_broadcast.c
> @@ -8,7 +8,6 @@
>  #include <linux/types.h>
>  #include <linux/module.h>
>  #include <linux/init.h>
> -#include <linux/errno.h>
>  #include <linux/netdevice.h>
>  #include <linux/if_team.h>
>  
> diff --git a/drivers/net/team/team_mode_roundrobin.c b/drivers/net/team/team_mode_roundrobin.c
> index 3ec63de97ae3..dd405d82c6ac 100644
> --- a/drivers/net/team/team_mode_roundrobin.c
> +++ b/drivers/net/team/team_mode_roundrobin.c
> @@ -8,7 +8,6 @@
>  #include <linux/types.h>
>  #include <linux/module.h>
>  #include <linux/init.h>
> -#include <linux/errno.h>
>  #include <linux/netdevice.h>
>  #include <linux/if_team.h>

-- 
pw-bot: changes-requested