netdev - Re: [PATCH net-next] team: remove unreferenced header in activebackup/broadcast/roundrobin files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Mon, 7 Aug 2023 09:01:48 +0800
From: shaozhengchao <shaozhengchao@...wei.com>
To: Simon Horman <horms@...nel.org>
CC: <netdev@...r.kernel.org>, <davem@...emloft.net>, <edumazet@...gle.com>,
	<kuba@...nel.org>, <pabeni@...hat.com>, <jiri@...nulli.us>,
	<weiyongjun1@...wei.com>, <yuehaibing@...wei.com>
Subject: Re: [PATCH net-next] team: remove unreferenced header in
 activebackup/broadcast/roundrobin files



On 2023/8/5 19:48, Simon Horman wrote:
> On Fri, Aug 04, 2023 at 07:30:35PM +0800, Zhengchao Shao wrote:
>> Because linux/errno.h is unreferenced in activebackup/broadcast/roundrobin
>> files, so remove it.
>>
>> Signed-off-by: Zhengchao Shao <shaozhengchao@...wei.com>
>> ---
>>   drivers/net/team/team_mode_activebackup.c | 1 -
>>   drivers/net/team/team_mode_broadcast.c    | 1 -
>>   drivers/net/team/team_mode_roundrobin.c   | 1 -
>>   3 files changed, 3 deletions(-)
>>
>> diff --git a/drivers/net/team/team_mode_activebackup.c b/drivers/net/team/team_mode_activebackup.c
>> index e0f599e2a51d..419b9083515e 100644
>> --- a/drivers/net/team/team_mode_activebackup.c
>> +++ b/drivers/net/team/team_mode_activebackup.c
>> @@ -8,7 +8,6 @@
>>   #include <linux/types.h>
>>   #include <linux/module.h>
>>   #include <linux/init.h>
>> -#include <linux/errno.h>
>>   #include <linux/netdevice.h>
>>   #include <net/rtnetlink.h>
>>   #include <linux/if_team.h>
> 
> Hi Zhengchao Shao,
> 
> Removing the inclusion of errno.h from team_mode_activebackup.c doesn't
> seem right to me, ENOENT is used in that file.
> 
> The other two below seem fine to me.
> 
Hi Simon:
	Thank you for your review. You are right here and I will send V2.

Zhengchao Shao
>> diff --git a/drivers/net/team/team_mode_broadcast.c b/drivers/net/team/team_mode_broadcast.c
>> index 313a3e2d68bf..61d7d79f0c36 100644
>> --- a/drivers/net/team/team_mode_broadcast.c
>> +++ b/drivers/net/team/team_mode_broadcast.c
>> @@ -8,7 +8,6 @@
>>   #include <linux/types.h>
>>   #include <linux/module.h>
>>   #include <linux/init.h>
>> -#include <linux/errno.h>
>>   #include <linux/netdevice.h>
>>   #include <linux/if_team.h>
>>   
>> diff --git a/drivers/net/team/team_mode_roundrobin.c b/drivers/net/team/team_mode_roundrobin.c
>> index 3ec63de97ae3..dd405d82c6ac 100644
>> --- a/drivers/net/team/team_mode_roundrobin.c
>> +++ b/drivers/net/team/team_mode_roundrobin.c
>> @@ -8,7 +8,6 @@
>>   #include <linux/types.h>
>>   #include <linux/module.h>
>>   #include <linux/init.h>
>> -#include <linux/errno.h>
>>   #include <linux/netdevice.h>
>>   #include <linux/if_team.h>
>