netdev - RE: Error 'netif_napi_add_weight() called with weight 256'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8fcbab1aa2e14262bea79222bf7a4976@realtek.com>
Date: Mon, 7 Aug 2023 09:57:15 +0000
From: Hayes Wang <hayeswang@...ltek.com>
To: "Limonciello, Mario" <mario.limonciello@....com>,
        Jakub Kicinski
	<kuba@...nel.org>
CC: "edumazet@...gle.com" <edumazet@...gle.com>,
        LKML
	<linux-kernel@...r.kernel.org>,
        "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "pabeni@...hat.com"
	<pabeni@...hat.com>,
        Paul Menzel <pmenzel@...gen.mpg.de>
Subject: RE: Error 'netif_napi_add_weight() called with weight 256'

Limonciello, Mario <mario.limonciello@....com>
> Sent: Tuesday, August 1, 2023 2:24 AM
[...]
> 
> > The custom weight is probably due to a misunderstanding. We have 200G
> > adapters using the standard weight of 64, IDK why 2.5G adapter would
> > need anything special.
> 
> Perhaps Hayes Wang can comment on this (as the author of 195aae321c82).

I test our devices on an Embedded system.
We find the throughput is low.
And it is caused by the weight.
Our NAPI function often uses the whole budget.
Finally, we increase the weight, and the throughput is good.

Best Regards,
Hayes