netdev - Re: Error 'netif_napi_add_weight() called with weight 256'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230807093727.5249f517@kernel.org>
Date: Mon, 7 Aug 2023 09:37:27 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Hayes Wang <hayeswang@...ltek.com>
Cc: "Limonciello, Mario" <mario.limonciello@....com>, "edumazet@...gle.com"
 <edumazet@...gle.com>, LKML <linux-kernel@...r.kernel.org>,
 "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "davem@...emloft.net"
 <davem@...emloft.net>, "linux-usb@...r.kernel.org"
 <linux-usb@...r.kernel.org>, "pabeni@...hat.com" <pabeni@...hat.com>, Paul
 Menzel <pmenzel@...gen.mpg.de>
Subject: Re: Error 'netif_napi_add_weight() called with weight 256'

On Mon, 7 Aug 2023 09:57:15 +0000 Hayes Wang wrote:
> > Perhaps Hayes Wang can comment on this (as the author of 195aae321c82).  
> 
> I test our devices on an Embedded system.
> We find the throughput is low.
> And it is caused by the weight.
> Our NAPI function often uses the whole budget.
> Finally, we increase the weight, and the throughput is good.

Could it possibly be related to handling of aggregation?
Problem must lay somewhere in USB specifics, since as I said
there are 100Gbps devices running fine with budget of 64.