netdev - RE: [PATCH iwl-next v3 0/3] ice: split ice_aq_wait_for

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CO1PR11MB5089E3BE7EFA7E9534F53038D60CA@CO1PR11MB5089.namprd11.prod.outlook.com>
Date: Mon, 7 Aug 2023 16:45:07 +0000
From: "Keller, Jacob E" <jacob.e.keller@...el.com>
To: "Kitszel, Przemyslaw" <przemyslaw.kitszel@...el.com>,
	"intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "Nguyen, Anthony L"
	<anthony.l.nguyen@...el.com>, Simon Horman <horms@...nel.org>
Subject: RE: [PATCH iwl-next v3 0/3] ice: split ice_aq_wait_for_event() func
 into two



> -----Original Message-----
> From: Kitszel, Przemyslaw <przemyslaw.kitszel@...el.com>
> Sent: Monday, August 7, 2023 8:59 AM
> To: intel-wired-lan@...ts.osuosl.org
> Cc: netdev@...r.kernel.org; Keller, Jacob E <jacob.e.keller@...el.com>; Nguyen,
> Anthony L <anthony.l.nguyen@...el.com>; Simon Horman <horms@...nel.org>;
> Kitszel, Przemyslaw <przemyslaw.kitszel@...el.com>
> Subject: [PATCH iwl-next v3 0/3] ice: split ice_aq_wait_for_event() func into two
> 
> Mitigate race between registering on wait list and receiving
> AQ Response from FW.
> 
> The first patch fixes bound check to be more inclusive;
> the second one refactors code to make the third one smaller,
> which is an actual fix for the race.
> 
> Thanks Simon Horman for pushing into split, it's easier to follow now.
> 
> v3: split into 3 commits
> 
> Przemek Kitszel (3):
>   ice: ice_aq_check_events: fix off-by-one check when filling buffer
>   ice: embed &ice_rq_event_info event into struct ice_aq_task
>   ice: split ice_aq_wait_for_event() func into two
> 
>  drivers/net/ethernet/intel/ice/ice.h          |  21 +++-
>  .../net/ethernet/intel/ice/ice_fw_update.c    |  45 ++++----
>  drivers/net/ethernet/intel/ice/ice_main.c     | 100 +++++++++---------
>  3 files changed, 94 insertions(+), 72 deletions(-)
> 
> 
> base-commit: 1efaa6ca8af14114dafb99924bc922daa135f870
> --
> 2.40.1

This series looks good to me.

Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>

Thanks,
Jake