netdev - Re: [PATCH net-next] net: mana: Add gdma stats to ethtool output for mana

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CALs4sv1OGqYguPUVoErc25tcEDetVA6z1ANjz9+vNp3q7WTR=Q@mail.gmail.com>
Date: Mon, 7 Aug 2023 20:20:11 +0530
From: Pavan Chebbi <pavan.chebbi@...adcom.com>
To: Shradha Gupta <shradhagupta@...ux.microsoft.com>
Cc: linux-kernel@...r.kernel.org, linux-hyperv@...r.kernel.org, 
	linux-rdma@...r.kernel.org, netdev@...r.kernel.org, 
	Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, 
	Ajay Sharma <sharmaajay@...rosoft.com>, Leon Romanovsky <leon@...nel.org>, 
	Thomas Gleixner <tglx@...utronix.de>, Sebastian Andrzej Siewior <bigeasy@...utronix.de>, 
	"K. Y. Srinivasan" <kys@...rosoft.com>, Haiyang Zhang <haiyangz@...rosoft.com>, Wei Liu <wei.liu@...nel.org>, 
	Dexuan Cui <decui@...rosoft.com>, Long Li <longli@...rosoft.com>, 
	Michael Kelley <mikelley@...rosoft.com>
Subject: Re: [PATCH net-next] net: mana: Add gdma stats to ethtool output for mana

On Mon, Aug 7, 2023 at 4:29 PM Shradha Gupta
<shradhagupta@...ux.microsoft.com> wrote:
>
> Extended performance counter stats in 'ethtool -S <interface>'
> for MANA VF to include GDMA tx LSO packets and bytes count.
>
> Tested-on: Ubuntu22
> Testcases:
> 1. LISA testcase:
> PERF-NETWORK-TCP-THROUGHPUT-MULTICONNECTION-NTTTCP-Synthetic
> 2. LISA testcase:
> PERF-NETWORK-TCP-THROUGHPUT-MULTICONNECTION-NTTTCP-SRIOV
> 3. Validated the GDMA stat packets and byte counters
> Signed-off-by: Shradha Gupta <shradhagupta@...ux.microsoft.com>
> ---
>  drivers/net/ethernet/microsoft/mana/mana_en.c | 40 +++++++++
>  .../ethernet/microsoft/mana/mana_ethtool.c    | 15 ++++
>  include/net/mana/mana.h                       | 88 +++++++++++++++++++
>  3 files changed, 143 insertions(+)
>
> diff --git a/drivers/net/ethernet/microsoft/mana/mana_en.c b/drivers/net/ethernet/microsoft/mana/mana_en.c
> index ac2acc9aca9d..eb5e4164b9bf 100644
> --- a/drivers/net/ethernet/microsoft/mana/mana_en.c
> +++ b/drivers/net/ethernet/microsoft/mana/mana_en.c
> @@ -2234,6 +2234,46 @@ int mana_config_rss(struct mana_port_context *apc, enum TRI_STATE rx,
>         return 0;
>  }
>
> +void mana_query_gf_stats(struct mana_port_context *apc)
> +{
> +       struct mana_query_gf_stat_req   req = {};

nit: remove the space before 'req' and rearrange in reverse x-mas order

> +       struct mana_query_gf_stat_resp resp = {};
> +       struct net_device *ndev = apc->ndev;

> +#define STATISTICS_FLAGS_HC_TX_BCAST_PACKETS           0x0000000001000000
> +#define STATISTICS_FLAGS_HC_TX_BCAST_BYTES             0x0000000002000000
> +/* Tx error */
> +#define STATISTICS_FLAGS_TX_ERRORS_GDMA_ERROR          0x0000000004000000
> +
> +

Checkpatch is warning about this.
Otherwise it looks good.

>  #define MANA_MAX_NUM_QUEUES 64
>
>  #define MANA_SHORT_VPORT_OFFSET_MAX ((1U << 8) - 1)
> --
> 2.34.1
>
>

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4209 bytes)