netdev - Re: [PATCH net-next v2 2/9] dpll: spec: Add Netlink spec in YAML

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a7e2f7e1-e36a-2c79-46c3-874550d24575@linux.dev>
Date: Mon, 7 Aug 2023 22:25:25 +0100
From: Vadim Fedorenko <vadim.fedorenko@...ux.dev>
To: Jiri Pirko <jiri@...nulli.us>
Cc: Jakub Kicinski <kuba@...nel.org>,
 Arkadiusz Kubalewski <arkadiusz.kubalewski@...el.com>,
 Jonathan Lemon <jonathan.lemon@...il.com>, Paolo Abeni <pabeni@...hat.com>,
 Milena Olech <milena.olech@...el.com>,
 Michal Michalik <michal.michalik@...el.com>,
 linux-arm-kernel@...ts.infradead.org, poros@...hat.com, mschmidt@...hat.com,
 netdev@...r.kernel.org, linux-clk@...r.kernel.org,
 Bart Van Assche <bvanassche@....org>, intel-wired-lan@...ts.osuosl.org,
 Simon Horman <simon.horman@...igine.com>
Subject: Re: [PATCH net-next v2 2/9] dpll: spec: Add Netlink spec in YAML

On 07/08/2023 08:56, Jiri Pirko wrote:
> Fri, Aug 04, 2023 at 09:04:47PM CEST, vadim.fedorenko@...ux.dev wrote:
>> Add a protocol spec for DPLL.
>> Add code generated from the spec.
>>
>> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
>> Signed-off-by: Michal Michalik <michal.michalik@...el.com>
>> Signed-off-by: Vadim Fedorenko <vadim.fedorenko@...ux.dev>
>> Signed-off-by: Arkadiusz Kubalewski <arkadiusz.kubalewski@...el.com>
>> ---
> 
> Hmm, running tools/net/ynl/ynl-regen.sh generates following diff:
> diff --git a/drivers/dpll/dpll_nl.c b/drivers/dpll/dpll_nl.c
> index ff3f55f0ca94..638e21a9a06d 100644
> --- a/drivers/dpll/dpll_nl.c
> +++ b/drivers/dpll/dpll_nl.c
> @@ -17,7 +17,6 @@ const struct nla_policy dpll_pin_parent_device_nl_policy[DPLL_A_PIN_STATE + 1] =
>   	[DPLL_A_PIN_PRIO] = { .type = NLA_U32, },
>   	[DPLL_A_PIN_STATE] = NLA_POLICY_RANGE(NLA_U8, 1, 3),
>   };
> -
>   const struct nla_policy dpll_pin_parent_pin_nl_policy[DPLL_A_PIN_STATE + 1] = {
>   	[DPLL_A_PIN_STATE] = NLA_POLICY_RANGE(NLA_U8, 1, 3),
>   	[DPLL_A_PIN_ID] = { .type = NLA_U32, },
> diff --git a/include/uapi/linux/dpll.h b/include/uapi/linux/dpll.h
> index f659fabb1041..18d4fda484e8 100644
> --- a/include/uapi/linux/dpll.h
> +++ b/include/uapi/linux/dpll.h
> @@ -163,7 +163,6 @@ enum dpll_a {
>   	DPLL_A_PIN_PARENT_DEVICE,
>   	DPLL_A_PIN_PARENT_PIN,
>   
> -	/* private: */
>   	__DPLL_A_MAX,
>   	DPLL_A_MAX = (__DPLL_A_MAX - 1)
>   };
> @@ -182,7 +181,6 @@ enum dpll_cmd {
>   	DPLL_CMD_PIN_DELETE_NTF,
>   	DPLL_CMD_PIN_CHANGE_NTF,
>   
> -	/* private: */
>   	__DPLL_CMD_MAX,
>   	DPLL_CMD_MAX = (__DPLL_CMD_MAX - 1)
>   };
> 
> Do you base this patchset on top of recent net-next? If not, please do
> rebase.
> 

Well, in my case after rebasing on latest net-next I got just part of 
your diff:

diff --git a/drivers/dpll/dpll_nl.c b/drivers/dpll/dpll_nl.c
index ff3f55f0ca94..638e21a9a06d 100644
--- a/drivers/dpll/dpll_nl.c
+++ b/drivers/dpll/dpll_nl.c
@@ -17,7 +17,6 @@ const struct nla_policy 
dpll_pin_parent_device_nl_policy[DPLL_A_PIN_STATE + 1] =
         [DPLL_A_PIN_PRIO] = { .type = NLA_U32, },
         [DPLL_A_PIN_STATE] = NLA_POLICY_RANGE(NLA_U8, 1, 3),
  };
-
  const struct nla_policy dpll_pin_parent_pin_nl_policy[DPLL_A_PIN_STATE 
+ 1] = {
         [DPLL_A_PIN_STATE] = NLA_POLICY_RANGE(NLA_U8, 1, 3),
         [DPLL_A_PIN_ID] = { .type = NLA_U32, },


The "/* private: */" comment was added to the generator after Simon's
comment. But I'll include this part into the next version.

> 
> Other than this, looks fine to me.
> 
> Signed-off-by: Jiri Pirko <jiri@...dia.com>

Thanks!