lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20230807143539.7461b319@kernel.org> Date: Mon, 7 Aug 2023 14:35:39 -0700 From: Jakub Kicinski <kuba@...nel.org> To: Thinh Tran <thinhtr@...ux.vnet.ibm.com> Cc: aelior@...vell.com, davem@...emloft.net, edumazet@...gle.com, manishc@...vell.com, netdev@...r.kernel.org, pabeni@...hat.com, skalluru@...vell.com, drc@...ux.vnet.ibm.com, abdhalee@...ibm.com, simon.horman@...igine.com Subject: Re: [PATCH v4] bnx2x: Fix error recovering in switch configuration On Mon, 7 Aug 2023 16:08:50 -0500 Thinh Tran wrote: > >> +static inline void bnx2x_stop_nic(struct bnx2x *bp) > > > > can't it live in bnx2x_cmn.c ? > It's in common header file for also being used by bnx2x_vfpf.c. And bnx2x_cmn.c is the common source file. I don't see why it has to be a static inline. >>> Why make it a static inline? > > Just make it inlined where it is called.
Powered by blists - more mailing lists