lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <ann5dn236wyjoz2v3lmvihh2f5ses7nwy7lpqlkpoxvpcxgbjp@7ys6bkodptek> Date: Mon, 7 Aug 2023 16:39:01 -0500 From: Andrew Halaney <ahalaney@...hat.com> To: Andrew Lunn <andrew@...n.ch> Cc: Bartosz Golaszewski <brgl@...ev.pl>, Andy Gross <agross@...nel.org>, Bjorn Andersson <andersson@...nel.org>, Konrad Dybcio <konrad.dybcio@...aro.org>, Rob Herring <robh+dt@...nel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>, Conor Dooley <conor+dt@...nel.org>, Alex Elder <elder@...aro.org>, Srini Kandagatla <srinivas.kandagatla@...aro.org>, linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, netdev@...r.kernel.org, Bartosz Golaszewski <bartosz.golaszewski@...aro.org> Subject: Re: [PATCH 1/9] arm64: dts: qcom: sa8775p: add a node for the second serdes PHY On Mon, Aug 07, 2023 at 11:28:15PM +0200, Andrew Lunn wrote: > On Mon, Aug 07, 2023 at 04:10:34PM -0500, Andrew Halaney wrote: > > On Mon, Aug 07, 2023 at 09:34:59PM +0200, Bartosz Golaszewski wrote: > > > From: Bartosz Golaszewski <bartosz.golaszewski@...aro.org> > > > > > > Add a node for the SerDes PHY used by EMAC1 on sa8775p-ride. > > > > > > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@...aro.org> > > > > FWIW this seems to match downstream sources. > > > > Reviewed-by: Andrew Halaney <ahalaney@...hat.com> > > Why does matching downstream make it correct and deserve a > Reviewed-by? > > Did you actually review the change? > > Andrew > That wording of "match downstream sources" is amiguous, sorry. What I meant was that: 1. This looks like a properly formatted dtsi node, follows conventions in the file for ordering, etc 2. The downstream devicetree from Qualcomm uses the same MMIO region same dependencies for clocks, etc. I do not have documentation to further review past that I didn't suspect anyone else would cross check this information, so I did and thought it deserves a RB after that. Please let me know if you'd rather I just leave a comment saying such without any formal tags (but I thought since the whole patch looks proper and that information looks correct compared to the "documentation" I have access to it deserved such). In the rest of this series review I may have used similar phrasing with respect to downstream, but that expanded description is what I meant in those cases as well. Thanks, Andrew
Powered by blists - more mailing lists