netdev - Re: [PATCH] net: phy: Don't disable irqs on shutdown if WoL is enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 8 Aug 2023 14:53:25 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Florian Fainelli <f.fainelli@...il.com>, "Russell King (Oracle)"
 <linux@...linux.org.uk>, Andrew Lunn <andrew@...n.ch>, Heiner Kallweit
 <hkallweit1@...il.com>
Cc: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>,
 Ioana Ciornei <ciorneiioana@...il.com>, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org, Ioana Ciornei <ioana.ciornei@....com>,
 Alexandru Ardelean <alexandru.ardelean@...log.com>, Andre Edich
 <andre.edich@...rochip.com>, Antoine Tenart <atenart@...nel.org>, Baruch
 Siach <baruch@...s.co.il>, Christophe Leroy <christophe.leroy@....fr>,
 Divya Koppera <Divya.Koppera@...rochip.com>, Hauke Mehrtens
 <hauke@...ke-m.de>, Jerome Brunet <jbrunet@...libre.com>, Kavya Sree
 Kotagiri <kavyasree.kotagiri@...rochip.com>, Linus Walleij
 <linus.walleij@...aro.org>, Marco Felsch <m.felsch@...gutronix.de>, Marek
 Vasut <marex@...x.de>, Martin Blumenstingl
 <martin.blumenstingl@...glemail.com>, Mathias Kresin <dev@...sin.me>, Maxim
 Kochetkov <fido_max@...ox.ru>, Michael Walle <michael@...le.cc>, Neil
 Armstrong <narmstrong@...libre.com>, Nisar Sayed
 <Nisar.Sayed@...rochip.com>, Oleksij Rempel <o.rempel@...gutronix.de>,
 Philippe Schenker <philippe.schenker@...adex.com>, Willy Liu
 <willy.liu@...ltek.com>, Yuiko Oshino <yuiko.oshino@...rochip.com>
Subject: Re: [PATCH] net: phy: Don't disable irqs on shutdown if WoL is
 enabled

On Fri,  4 Aug 2023 09:17:57 +0200 Uwe Kleine-König wrote:
> Most PHYs signal WoL using an interrupt. So disabling interrupts breaks
> WoL at least on PHYs covered by the marvell driver. So skip disabling
> irqs on shutdown if WoL is enabled.
> 
> While at it also explain the motivation that irqs are disabled at all.
> 
> Fixes: e2f016cf7751 ("net: phy: add a shutdown procedure")
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>

What do we do with this one? It sounded like Russell was leaning
towards a revert?

FTR original report:
https://lore.kernel.org/all/20230803181640.yzxsk2xphwryxww4@pengutronix.de/

> while I'm not sure that disabling interrupts is a good idea in general,
> this change at least should fix the WoL case. Note that this change is
> only compile tested as next doesn't boot on my test machine (because of
> https://git.kernel.org/linus/b3574f579ece24439c90e9a179742c61205fbcfa)
> and 6.1 (which is the other kernel I have running) doesn't know about
> .wol_enabled. I don't want to delay this fix until I bisected this new
> issue.
> 
> Assuming this patch is eligible for backporting to stable, maybe point
> out that it depends on v6.5-rc1~163^2~286^2~2 ("net: phy: Allow drivers
> to always call into ->suspend()"). Didn't try to backport that.
> 
> Best regards
> Uwe
> 
>  drivers/net/phy/phy_device.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c
> index 61921d4dbb13..6d1526bdd1d7 100644
> --- a/drivers/net/phy/phy_device.c
> +++ b/drivers/net/phy/phy_device.c
> @@ -3340,6 +3340,15 @@ static void phy_shutdown(struct device *dev)
>  	if (phydev->state == PHY_READY || !phydev->attached_dev)
>  		return;
>  
> +	/* Most phys signal WoL via the irq line. So for these irqs shouldn't be
> +	 * disabled.
> +	 */
> +	if (phydev->wol_enabled)
> +		return;
> +
> +	/* On shutdown disable irqs to prevent an irq storm on systems where the
> +	 * irq line is shared by several devices.
> +	 */
>  	phy_disable_interrupts(phydev);
>  }
>