netdev - Re: [PATCH] net: phy: Don't disable irqs on shutdown if WoL is enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 8 Aug 2023 14:59:41 -0700
From: Florian Fainelli <f.fainelli@...il.com>
To: Jakub Kicinski <kuba@...nel.org>,
 "Russell King (Oracle)" <linux@...linux.org.uk>, Andrew Lunn
 <andrew@...n.ch>, Heiner Kallweit <hkallweit1@...il.com>
Cc: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>,
 Ioana Ciornei <ciorneiioana@...il.com>, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org, Ioana Ciornei <ioana.ciornei@....com>,
 Alexandru Ardelean <alexandru.ardelean@...log.com>,
 Andre Edich <andre.edich@...rochip.com>, Antoine Tenart
 <atenart@...nel.org>, Baruch Siach <baruch@...s.co.il>,
 Christophe Leroy <christophe.leroy@....fr>,
 Divya Koppera <Divya.Koppera@...rochip.com>,
 Hauke Mehrtens <hauke@...ke-m.de>, Jerome Brunet <jbrunet@...libre.com>,
 Kavya Sree Kotagiri <kavyasree.kotagiri@...rochip.com>,
 Linus Walleij <linus.walleij@...aro.org>,
 Marco Felsch <m.felsch@...gutronix.de>, Marek Vasut <marex@...x.de>,
 Martin Blumenstingl <martin.blumenstingl@...glemail.com>,
 Mathias Kresin <dev@...sin.me>, Maxim Kochetkov <fido_max@...ox.ru>,
 Michael Walle <michael@...le.cc>, Neil Armstrong <narmstrong@...libre.com>,
 Nisar Sayed <Nisar.Sayed@...rochip.com>,
 Oleksij Rempel <o.rempel@...gutronix.de>,
 Philippe Schenker <philippe.schenker@...adex.com>,
 Willy Liu <willy.liu@...ltek.com>, Yuiko Oshino <yuiko.oshino@...rochip.com>
Subject: Re: [PATCH] net: phy: Don't disable irqs on shutdown if WoL is
 enabled

On 8/8/23 14:53, Jakub Kicinski wrote:
> On Fri,  4 Aug 2023 09:17:57 +0200 Uwe Kleine-König wrote:
>> Most PHYs signal WoL using an interrupt. So disabling interrupts breaks
>> WoL at least on PHYs covered by the marvell driver. So skip disabling
>> irqs on shutdown if WoL is enabled.
>>
>> While at it also explain the motivation that irqs are disabled at all.
>>
>> Fixes: e2f016cf7751 ("net: phy: add a shutdown procedure")
>> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> 
> What do we do with this one? It sounded like Russell was leaning
> towards a revert?

Yes, though I believe this will create a different kind of regression 
for what Iona was addressing initially. Then it becomes a choice of 
which regression do we consider to be the worst to handle until 
something better comes up.

Russell what are your thoughts?
-- 
Florian