netdev - Re: [PATCH v12 12/26] nvme-tcp: Only enable offload with TLS if the driver supports it

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <02837791-9e54-5b17-28a5-0df35bb93806@grimberg.me>
Date: Wed, 9 Aug 2023 11:05:01 +0300
From: Sagi Grimberg <sagi@...mberg.me>
To: Aurelien Aptel <aaptel@...dia.com>, linux-nvme@...ts.infradead.org,
 netdev@...r.kernel.org, hch@....de, kbusch@...nel.org, axboe@...com,
 chaitanyak@...dia.com, davem@...emloft.net, kuba@...nel.org
Cc: aurelien.aptel@...il.com, smalin@...dia.com, malin1024@...il.com,
 ogerlitz@...dia.com, yorayz@...dia.com, borisp@...dia.com,
 galshalom@...dia.com, mgurtovoy@...dia.com
Subject: Re: [PATCH v12 12/26] nvme-tcp: Only enable offload with TLS if the
 driver supports it



On 7/12/23 19:14, Aurelien Aptel wrote:
> Check if ULP offload driver supports ULP-over-TLS before enabling the
> offload with tls.
> 
> Signed-off-by: Aurelien Aptel <aaptel@...dia.com>
> Signed-off-by: Shai Malin <smalin@...dia.com>
> Reviewed-by: Max Gurtovoy <mgurtovoy@...dia.com>
> ---
>   drivers/nvme/host/tcp.c | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/nvme/host/tcp.c b/drivers/nvme/host/tcp.c
> index e560bdf3a023..afb3dedcbc0c 100644
> --- a/drivers/nvme/host/tcp.c
> +++ b/drivers/nvme/host/tcp.c
> @@ -367,6 +367,10 @@ static inline bool is_netdev_ulp_offload_active(struct net_device *netdev,
>   	if (!nvme_tcp_ddp_query_limits(netdev, queue))
>   		return false;
>   
> +	/* If we are using TLS and netdev doesn't support it, do not offload */
> +	if (queue->ctrl->ctrl.opts->tls && !queue->ddp_limits.tls)
> +		return false;

Same for this, fold to the first patch.

Other than that I had a question on one of my other responses.
I don't think that tls_device supports 1.3, so what does tls
here mean? That any device that enables this supports _all_
tls versions?