netdev - Re: [PATCH v2] netfilter: ebtables: fix fortify warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b78cdc3b-8e08-6c75-de8e-15946789056f@huaweicloud.com>
Date: Wed, 9 Aug 2023 11:25:44 +0800
From: "GONG, Ruiqi" <gongruiqi@...weicloud.com>
To: "Gustavo A. R. Silva" <gustavoars@...nel.org>
Cc: Pablo Neira Ayuso <pablo@...filter.org>,
 Jozsef Kadlecsik <kadlec@...filter.org>, Florian Westphal <fw@...len.de>,
 Roopa Prabhu <roopa@...dia.com>, Nikolay Aleksandrov <razor@...ckwall.org>,
 Kees Cook <keescook@...omium.org>, netfilter-devel@...r.kernel.org,
 coreteam@...filter.org, netdev@...r.kernel.org,
 linux-hardening@...r.kernel.org, linux-kernel@...r.kernel.org,
 Wang Weiyang <wangweiyang2@...wei.com>, Xiu Jianfeng
 <xiujianfeng@...wei.com>, gongruiqi1@...wei.com
Subject: Re: [PATCH v2] netfilter: ebtables: fix fortify warnings

On 2023/08/09 0:32, Gustavo A. R. Silva wrote:
>
> [...]
>
>> diff --git a/net/bridge/netfilter/ebtables.c b/net/bridge/netfilter/ebtables.c
>> index 757ec46fc45a..5ec66b1ebb64 100644
>> --- a/net/bridge/netfilter/ebtables.c
>> +++ b/net/bridge/netfilter/ebtables.c
>> @@ -2115,8 +2115,7 @@ static int size_entry_mwt(const struct ebt_entry *entry, const unsigned char *ba
>>  		return ret;
>>  
>>  	offsets[0] = sizeof(struct ebt_entry); /* matches come first */
>> -	memcpy(&offsets[1], &entry->watchers_offset,
>> -			sizeof(offsets) - sizeof(offsets[0]));
>> +	memcpy(&offsets[1], &entry->offsets, sizeof(offsets) - sizeof(offsets[0]));
> 							^^^^^^^^^^^^
> You now can replace this ____________________________________|
> with just `sizeof(entry->offsets)`
> 
> With that change you can add my
> Reviewed-by: Gustavo A. R. Silva <gustavoars@...nel.org>
> 
> Thank you
> --
> Gustavo
> 

Will do. Thanks for the suggestion & review!

>>  
>>  	if (state->buf_kern_start) {
>>  		buf_start = state->buf_kern_start + state->buf_kern_offset;
>> -- 
>> 2.41.0
>>