netdev - Re: [PATCH] net: ipmr: Call ipmr_ioctl() directly from ipmr_sk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 9 Aug 2023 11:26:19 +0800
From: kernel test robot <lkp@...el.com>
To: Gustavo Luiz Duarte <gustavold@...il.com>, netdev@...r.kernel.org
Cc: oe-kbuild-all@...ts.linux.dev, Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	David Ahern <dsahern@...nel.org>, Breno Leitao <leitao@...ian.org>,
	Willem de Bruijn <willemb@...gle.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: ipmr: Call ipmr_ioctl() directly from
 ipmr_sk_ioctl()

Hi Gustavo,

kernel test robot noticed the following build errors:

[auto build test ERROR on net/main]
[also build test ERROR on net-next/main linus/master v6.5-rc5 next-20230808]
[cannot apply to horms-ipvs/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Gustavo-Luiz-Duarte/net-ipmr-Call-ipmr_ioctl-directly-from-ipmr_sk_ioctl/20230731-225918
base:   net/main
patch link:    https://lore.kernel.org/r/20230731145713.178509-1-gustavold%40gmail.com
patch subject: [PATCH] net: ipmr: Call ipmr_ioctl() directly from ipmr_sk_ioctl()
config: x86_64-randconfig-x054-20230808 (https://download.01.org/0day-ci/archive/20230809/202308091122.z4eVvCI5-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce: (https://download.01.org/0day-ci/archive/20230809/202308091122.z4eVvCI5-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202308091122.z4eVvCI5-lkp@intel.com/

All errors (new ones prefixed by >>):

   ld: net/core/sock.o: in function `ip6mr_sk_ioctl':
>> include/linux/mroute6.h:115: undefined reference to `ip6mr_ioctl'
>> ld: include/linux/mroute6.h:130: undefined reference to `ip6mr_ioctl'


vim +115 include/linux/mroute6.h

    95	
    96	struct rtmsg;
    97	extern int ip6mr_get_route(struct net *net, struct sk_buff *skb,
    98				   struct rtmsg *rtm, u32 portid);
    99	
   100	#ifdef CONFIG_IPV6_MROUTE
   101	bool mroute6_is_socket(struct net *net, struct sk_buff *skb);
   102	extern int ip6mr_sk_done(struct sock *sk);
   103	static inline int ip6mr_sk_ioctl(struct sock *sk, unsigned int cmd,
   104					 void __user *arg)
   105	{
   106		int ret;
   107	
   108		switch (cmd) {
   109		case SIOCGETMIFCNT_IN6: {
   110			struct sioc_mif_req6 karg;
   111	
   112			if (copy_from_user(&karg, arg, sizeof(karg)))
   113				return -EFAULT;
   114	
 > 115			ret = ip6mr_ioctl(sk, cmd, &karg);
   116			if (ret)
   117				return ret;
   118	
   119			if (copy_to_user(arg, &karg, sizeof(karg)))
   120				return -EFAULT;
   121	
   122			return 0;
   123			}
   124		case SIOCGETSGCNT_IN6: {
   125			struct sioc_sg_req6 karg;
   126	
   127			if (copy_from_user(&karg, arg, sizeof(karg)))
   128				return -EFAULT;
   129	
 > 130			ret = ip6mr_ioctl(sk, cmd, &karg);
   131			if (ret)
   132				return ret;
   133	
   134			if (copy_to_user(arg, &karg, sizeof(karg)))
   135				return -EFAULT;
   136	
   137			return 0;
   138			}
   139		}
   140	
   141		return 1;
   142	}
   143	#else
   144	static inline bool mroute6_is_socket(struct net *net, struct sk_buff *skb)
   145	{
   146		return false;
   147	}
   148	static inline int ip6mr_sk_done(struct sock *sk)
   149	{
   150		return 0;
   151	}
   152	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki