[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <253jzu3vtnf.fsf@nvidia.com>
Date: Thu, 10 Aug 2023 17:50:12 +0300
From: Aurelien Aptel <aaptel@...dia.com>
To: Sagi Grimberg <sagi@...mberg.me>, linux-nvme@...ts.infradead.org,
netdev@...r.kernel.org, hch@....de, kbusch@...nel.org, axboe@...com,
chaitanyak@...dia.com, davem@...emloft.net, kuba@...nel.org
Cc: aurelien.aptel@...il.com, smalin@...dia.com, malin1024@...il.com,
ogerlitz@...dia.com, yorayz@...dia.com, borisp@...dia.com,
galshalom@...dia.com, mgurtovoy@...dia.com
Subject: Re: [PATCH v12 11/26] nvme-tcp: Add modparam to control the ULP
offload enablement
Sagi Grimberg <sagi@...mberg.me> writes:
>> +static bool ulp_offload;
>> +module_param(ulp_offload, bool, 0644);
>> +MODULE_PARM_DESC(ulp_offload, "Enable or disable NVMeTCP ULP support");
>
> the name is strange.
> maybe call it ddp_offload?
> and in the description spell it as "direct data placement"
Sure.
> This patch should be folded to the control path. No reason for it to
> stand on its own I think.
Sure, we will fold it.
Thanks
Powered by blists - more mailing lists