netdev - Re: [PATCH v12 12/26] nvme-tcp: Only enable offload with TLS if the driver supports it

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <253h6p7vtkc.fsf@nvidia.com>
Date: Thu, 10 Aug 2023 17:52:03 +0300
From: Aurelien Aptel <aaptel@...dia.com>
To: Sagi Grimberg <sagi@...mberg.me>, linux-nvme@...ts.infradead.org,
 netdev@...r.kernel.org, hch@....de, kbusch@...nel.org, axboe@...com,
 chaitanyak@...dia.com, davem@...emloft.net, kuba@...nel.org
Cc: aurelien.aptel@...il.com, smalin@...dia.com, malin1024@...il.com,
 ogerlitz@...dia.com, yorayz@...dia.com, borisp@...dia.com,
 galshalom@...dia.com, mgurtovoy@...dia.com
Subject: Re: [PATCH v12 12/26] nvme-tcp: Only enable offload with TLS if the
 driver supports it

Sagi Grimberg <sagi@...mberg.me> writes:
>> +     /* If we are using TLS and netdev doesn't support it, do not offload */
>> +     if (queue->ctrl->ctrl.opts->tls && !queue->ddp_limits.tls)
>> +             return false;
>
> Same for this, fold to the first patch.

Ok

> Other than that I had a question on one of my other responses.
> I don't think that tls_device supports 1.3, so what does tls
> here mean? That any device that enables this supports _all_
> tls versions?

This is a catch-all for all TLS versions.
We can split the logic between TLS version once a HW device will allow it.

Thanks