lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <ZNX0IFu0td1YtY7L@nanopsycho> Date: Fri, 11 Aug 2023 10:41:04 +0200 From: Jiri Pirko <jiri@...nulli.us> To: Jakub Kicinski <kuba@...nel.org> Cc: netdev@...r.kernel.org, pabeni@...hat.com, davem@...emloft.net, edumazet@...gle.com, moshe@...dia.com, saeedm@...dia.com, idosch@...dia.com, petrm@...dia.com Subject: Re: [patch net-next v3 10/13] devlink: allow user to narrow per-instance dumps by passing handle attrs Fri, Aug 11, 2023 at 04:17:22AM CEST, kuba@...nel.org wrote: >On Thu, 10 Aug 2023 15:15:36 +0200 Jiri Pirko wrote: >> + struct nlattr **attrs = info->attrs; >> + int flags = NLM_F_MULTI; >> + >> + if (attrs) >> + flags |= NLM_F_DUMP_FILTERED; > >Are attrs NULL if user passed no TLVs? True, I fixed this for v4. >TBH I'm not sure how valuable NLM_F_DUMP_FILTERED is in the first place. Yeah, I just noticed this flag, so I decided to throw it in. I don't see any harm in that. And I believe it is actually correct to use this flag.
Powered by blists - more mailing lists