netdev - Re: [patch net-next v3 10/13] devlink: allow user to narrow per-instance dumps by passing handle attrs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230810191722.7c19f190@kernel.org>
Date: Thu, 10 Aug 2023 19:17:22 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Jiri Pirko <jiri@...nulli.us>
Cc: netdev@...r.kernel.org, pabeni@...hat.com, davem@...emloft.net,
 edumazet@...gle.com, moshe@...dia.com, saeedm@...dia.com,
 idosch@...dia.com, petrm@...dia.com
Subject: Re: [patch net-next v3 10/13] devlink: allow user to narrow
 per-instance dumps by passing handle attrs

On Thu, 10 Aug 2023 15:15:36 +0200 Jiri Pirko wrote:
> +	struct nlattr **attrs = info->attrs;
> +	int flags = NLM_F_MULTI;
> +
> +	if (attrs)
> +		flags |= NLM_F_DUMP_FILTERED;

Are attrs NULL if user passed no TLVs?
TBH I'm not sure how valuable NLM_F_DUMP_FILTERED is in the first place.