netdev - Re: [PATCH net-next v2 2/5] ice: configure FW logging

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZNYH705yA5qGxnvJ@vergenet.net>
Date: Fri, 11 Aug 2023 12:05:35 +0200
From: Simon Horman <horms@...nel.org>
To: Tony Nguyen <anthony.l.nguyen@...el.com>
Cc: davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com,
	edumazet@...gle.com, netdev@...r.kernel.org,
	Paul M Stillwell Jr <paul.m.stillwell.jr@...el.com>,
	jacob.e.keller@...el.com,
	Pucha Himasekhar Reddy <himasekharx.reddy.pucha@...el.com>
Subject: Re: [PATCH net-next v2 2/5] ice: configure FW logging

On Thu, Aug 10, 2023 at 10:01:06AM -0700, Tony Nguyen wrote:
> From: Paul M Stillwell Jr <paul.m.stillwell.jr@...el.com>
> 
> Users want the ability to debug FW issues by retrieving the
> FW logs from the E8xx devices. Use debugfs to allow the user to
> read/write the FW log configuration by adding a 'fwlog/modules' file.
> Reading the file will show either the currently running configuration or
> the next configuration (if the user has changed the configuration).
> Writing to the file will update the configuration, but NOT enable the
> configuration (that is a separate command).

...

> @@ -5635,10 +5653,14 @@ static int __init ice_module_init(void)
>  		goto err_dest_wq;
>  	}
>  
> +	ice_debugfs_init();
> +
>  	status = pci_register_driver(&ice_driver);
>  	if (status) {
>  		pr_err("failed to register PCI driver, err %d\n", status);
>  		goto err_dest_lag_wq;
> +		destroy_workqueue(ice_wq);
> +		ice_debugfs_exit();

Hi Paul and Tony,

this new code seems to be unreachable.
Should it go before the goto statement?

>  	}
>  
>  	return 0;

...