lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20230811151600.6d59eaad@kernel.org> Date: Fri, 11 Aug 2023 15:16:00 -0700 From: Jakub Kicinski <kuba@...nel.org> To: Simon Horman <horms@...nel.org> Cc: Tony Nguyen <anthony.l.nguyen@...el.com>, davem@...emloft.net, pabeni@...hat.com, edumazet@...gle.com, netdev@...r.kernel.org, Paul M Stillwell Jr <paul.m.stillwell.jr@...el.com>, jacob.e.keller@...el.com, Pucha Himasekhar Reddy <himasekharx.reddy.pucha@...el.com> Subject: Re: [PATCH net-next v2 2/5] ice: configure FW logging On Fri, 11 Aug 2023 12:05:35 +0200 Simon Horman wrote: > > if (status) { > > pr_err("failed to register PCI driver, err %d\n", status); > > goto err_dest_lag_wq; > > + destroy_workqueue(ice_wq); > > + ice_debugfs_exit(); > > Hi Paul and Tony, > > this new code seems to be unreachable. > Should it go before the goto statement? :o catch of the week! :) -- pw-bot: cr
Powered by blists - more mailing lists