netdev - Re: [PATCH net v2] devlink: Delay health recover notification until devlink registered

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 11 Aug 2023 14:42:31 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Jiri Pirko <jiri@...nulli.us>
Cc: Shay Drory <shayd@...dia.com>, netdev@...r.kernel.org,
 pabeni@...hat.com, davem@...emloft.net, edumazet@...gle.com, Jiri Pirko
 <jiri@...dia.com>
Subject: Re: [PATCH net v2] devlink: Delay health recover notification until
 devlink registered

On Fri, 11 Aug 2023 10:05:03 +0200 Jiri Pirko wrote:
> This patch is not about user accessing it, this is about
> notification that would be tried to send before the instance is
> registered. So the lock scheme you suggest is not necessary. What helps
> is to move devl_port_health_reporter_create() call after register.

We moved to a model where the instance is registered early,
why is the driver not registering the instance early?

My first choice would be to fix the driver rather than adjust
the behavior of the core, and I'm hearing no solid reason why
that's not possible.

> We have the same issue with mlxsw where this notification may be called
> before register from mlxsw_core_health_event_work()

mlxsw? I somehow assumed this patch was for mlx5.. 
Quality commit message :|

> Limiting the creation of health reporter only when instance is
> registered does not seem like a good solution to me.
> 
> As with any other object, we postpone the notifications only after
> register is done, that sounds fine, doesn't it?

No, it doesn't. Registering health reporters on a semi-initialized
device is a major foot gun, we should not allow this unless really
necessary.