lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <CANn89iLYPk1VpcOACBki6CE82nPp9vD7akZSbBYD+-BVb_0zBQ@mail.gmail.com> Date: Fri, 11 Aug 2023 09:38:42 +0200 From: Eric Dumazet <edumazet@...gle.com> To: menglong8.dong@...il.com Cc: ncardwell@...gle.com, davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com, dsahern@...nel.org, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, flyingpeng@...cent.com, Menglong Dong <imagedong@...cent.com> Subject: Re: [PATCH net-next v4 4/4] net: tcp: refactor the dbg message in tcp_retransmit_timer() On Fri, Aug 11, 2023 at 5:01 AM <menglong8.dong@...il.com> wrote: > > From: Menglong Dong <imagedong@...cent.com> > > The debug message in tcp_retransmit_timer() is slightly wrong, because > they could be printed even if we did not receive a new ACK packet from > the remote peer. > > Change it to probing zero-window, as it is a expected case now. The > description may be not correct. > > Adding the duration since the last ACK we received, and the duration of > the retransmission, which are useful for debugging. > > And the message now like this: > > Probing zero-window on 127.0.0.1:9999/46946, seq=3737778959:3737791503, recv 209ms ago, lasting 209ms > Probing zero-window on 127.0.0.1:9999/46946, seq=3737778959:3737791503, recv 404ms ago, lasting 408ms > Probing zero-window on 127.0.0.1:9999/46946, seq=3737778959:3737791503, recv 812ms ago, lasting 1224ms Reviewed-by: Eric Dumazet <edumazet@...gle.com>
Powered by blists - more mailing lists