netdev - Re: [PATCH net v2] devlink: Delay health recover notification until devlink registered

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <922f30b7-69e0-77dc-6e21-8a16d7a4979a@nvidia.com>
Date: Sun, 13 Aug 2023 13:12:33 +0300
From: Shay Drory <shayd@...dia.com>
To: Jakub Kicinski <kuba@...nel.org>, Jiri Pirko <jiri@...nulli.us>
CC: <netdev@...r.kernel.org>, <pabeni@...hat.com>, <davem@...emloft.net>,
	<edumazet@...gle.com>, Jiri Pirko <jiri@...dia.com>
Subject: Re: [PATCH net v2] devlink: Delay health recover notification until
 devlink registered


On 12/08/2023 1:14, Jakub Kicinski wrote:
> External email: Use caution opening links or attachments
>
>
> On Fri, 11 Aug 2023 14:42:31 -0700 Jakub Kicinski wrote:
>>> Limiting the creation of health reporter only when instance is
>>> registered does not seem like a good solution to me.
>>>
>>> As with any other object, we postpone the notifications only after
>>> register is done, that sounds fine, doesn't it?
>> No, it doesn't. Registering health reporters on a semi-initialized
>> device is a major foot gun, we should not allow this unless really
>> necessary.
> FWIW I mean that the recovery may race with the init and try to access
> things which aren't set up yet. Could lead to deadlocks or crashes at
> worst and sprinkling of "if (!initialized) return;" at best.
> All the same problems we had before reload was put under the instance
> lock basically.


Ack, will work on it and send a new patch.