netdev - Re: [PATCH net-next] page_pool: Set page pool size.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Mon, 14 Aug 2023 10:44:08 +0200
From: Jesper Dangaard Brouer <jbrouer@...hat.com>
To: Ratheesh Kannoth <rkannoth@...vell.com>, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org
Cc: brouer@...hat.com, davem@...emloft.net, edumazet@...gle.com,
 kuba@...nel.org, pabeni@...hat.com, hawk@...nel.org,
 alexander.duyck@...il.com, ilias.apalodimas@...aro.org,
 linyunsheng@...wei.com, Alexander Lobakin <aleksander.lobakin@...el.com>
Subject: Re: [PATCH net-next] page_pool: Set page pool size.

On 09/08/2023 04.19, Ratheesh Kannoth wrote:
> https://lore.kernel.org/netdev/
> 	15d32b22-22b0-64e3-a49e-88d780c24616@...nel.org/T/
> 

For the record I like this code change better than changing page_pool
core code. I like and agree with Olek's (Alexander Lobakin) suggestion.

But the commit message need to be improved as it is too thin.
(And link is getting split in two lines for some reason)

> Suggested-by: Alexander Lobakin <aleksander.lobakin@...el.com>
> Signed-off-by: Ratheesh Kannoth <rkannoth@...vell.com>
> ---
>   drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c
> index 8336cea16aff..2986e238104e 100644
> --- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c
> +++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c
> @@ -1434,7 +1434,8 @@ int otx2_pool_init(struct otx2_nic *pfvf, u16 pool_id,
>   	}
>   
>   	pp_params.flags = PP_FLAG_PAGE_FRAG | PP_FLAG_DMA_MAP;
> -	pp_params.pool_size = numptrs;
> +#define OTX2_PAGE_POOL_SIZE 2048
> +	pp_params.pool_size = OTX2_PAGE_POOL_SIZE;
>   	pp_params.nid = NUMA_NO_NODE;
>   	pp_params.dev = pfvf->dev;
>   	pp_params.dma_dir = DMA_FROM_DEVICE;