| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <cceef8a4-6f38-bfd4-4f77-5dffa558b287@kernel.org> Date: Mon, 14 Aug 2023 10:45:42 +0200 From: Jesper Dangaard Brouer <hawk@...nel.org> To: Ratheesh Kannoth <rkannoth@...vell.com>, Johannes Berg <johannes@...solutions.net>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Cc: hawk@...nel.org, "davem@...emloft.net" <davem@...emloft.net>, "edumazet@...gle.com" <edumazet@...gle.com>, "kuba@...nel.org" <kuba@...nel.org>, "pabeni@...hat.com" <pabeni@...hat.com>, "ast@...nel.org" <ast@...nel.org>, "daniel@...earbox.net" <daniel@...earbox.net>, "john.fastabend@...il.com" <john.fastabend@...il.com>, "jiawenwu@...stnetic.com" <jiawenwu@...stnetic.com>, "mengyuanlou@...-swift.com" <mengyuanlou@...-swift.com>, "yang.lee@...ux.alibaba.com" <yang.lee@...ux.alibaba.com>, "error27@...il.com" <error27@...il.com>, "linyunsheng@...wei.com" <linyunsheng@...wei.com>, "linux-hyperv@...r.kernel.org" <linux-hyperv@...r.kernel.org>, "kys@...rosoft.com" <kys@...rosoft.com>, "haiyangz@...rosoft.com" <haiyangz@...rosoft.com>, "wei.liu@...nel.org" <wei.liu@...nel.org>, "decui@...rosoft.com" <decui@...rosoft.com>, "longli@...rosoft.com" <longli@...rosoft.com>, "shradhagupta@...ux.microsoft.com" <shradhagupta@...ux.microsoft.com>, "linux-hwmon@...r.kernel.org" <linux-hwmon@...r.kernel.org>, "michael.chan@...adcom.com" <michael.chan@...adcom.com>, "richardcochran@...il.com" <richardcochran@...il.com>, "jdelvare@...e.com" <jdelvare@...e.com>, "linux@...ck-us.net" <linux@...ck-us.net>, "yisen.zhuang@...wei.com" <yisen.zhuang@...wei.com>, "salil.mehta@...wei.com" <salil.mehta@...wei.com>, "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>, "linux-mediatek@...ts.infradead.org" <linux-mediatek@...ts.infradead.org>, "nbd@....name" <nbd@....name>, "john@...ozen.org" <john@...ozen.org>, "sean.wang@...iatek.com" <sean.wang@...iatek.com>, "Mark-MC.Lee@...iatek.com" <Mark-MC.Lee@...iatek.com>, "lorenzo@...nel.org" <lorenzo@...nel.org>, "matthias.bgg@...il.com" <matthias.bgg@...il.com>, "angelogioacchino.delregno@...labora.com" <angelogioacchino.delregno@...labora.com>, "linux@...linux.org.uk" <linux@...linux.org.uk>, "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>, "saeedm@...dia.com" <saeedm@...dia.com>, "leon@...nel.org" <leon@...nel.org>, "gerhard@...leder-embedded.com" <gerhard@...leder-embedded.com>, "maciej.fijalkowski@...el.com" <maciej.fijalkowski@...el.com>, "alexanderduyck@...com" <alexanderduyck@...com>, "wei.fang@....com" <wei.fang@....com>, "shenwei.wang@....com" <shenwei.wang@....com>, "xiaoning.wang@....com" <xiaoning.wang@....com>, "linux-imx@....com" <linux-imx@....com>, "lgirdwood@...il.com" <lgirdwood@...il.com>, "broonie@...nel.org" <broonie@...nel.org>, "jaswinder.singh@...aro.org" <jaswinder.singh@...aro.org>, "ilias.apalodimas@...aro.org" <ilias.apalodimas@...aro.org>, "UNGLinuxDriver@...rochip.com" <UNGLinuxDriver@...rochip.com>, "horatiu.vultur@...rochip.com" <horatiu.vultur@...rochip.com>, "linux-omap@...r.kernel.org" <linux-omap@...r.kernel.org>, "grygorii.strashko@...com" <grygorii.strashko@...com>, "simon.horman@...igine.com" <simon.horman@...igine.com>, "vladimir.oltean@....com" <vladimir.oltean@....com>, "aleksander.lobakin@...el.com" <aleksander.lobakin@...el.com>, "linux-stm32@...md-mailman.stormreply.com" <linux-stm32@...md-mailman.stormreply.com>, "alexandre.torgue@...s.st.com" <alexandre.torgue@...s.st.com>, "joabreu@...opsys.com" <joabreu@...opsys.com>, "mcoquelin.stm32@...il.com" <mcoquelin.stm32@...il.com>, "p.zabel@...gutronix.de" <p.zabel@...gutronix.de>, "thomas.petazzoni@...tlin.com" <thomas.petazzoni@...tlin.com>, "mw@...ihalf.com" <mw@...ihalf.com>, Sunil Kovvuri Goutham <sgoutham@...vell.com>, Geethasowjanya Akula <gakula@...vell.com>, Subbaraya Sundeep Bhatta <sbhatta@...vell.com>, Hariprasad Kelam <hkelam@...vell.com>, "xen-devel@...ts.xenproject.org" <xen-devel@...ts.xenproject.org>, "jgross@...e.com" <jgross@...e.com>, "sstabellini@...nel.org" <sstabellini@...nel.org>, "oleksandr_tyshchenko@...m.com" <oleksandr_tyshchenko@...m.com>, "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>, "ryder.lee@...iatek.com" <ryder.lee@...iatek.com>, "shayne.chen@...iatek.com" <shayne.chen@...iatek.com>, "kvalo@...nel.org" <kvalo@...nel.org>, "andrii@...nel.org" <andrii@...nel.org>, "martin.lau@...ux.dev" <martin.lau@...ux.dev>, "song@...nel.org" <song@...nel.org>, "yonghong.song@...ux.dev" <yonghong.song@...ux.dev>, "kpsingh@...nel.org" <kpsingh@...nel.org>, "sdf@...gle.com" <sdf@...gle.com>, "haoluo@...gle.com" <haoluo@...gle.com>, "jolsa@...nel.org" <jolsa@...nel.org> Subject: Re: [EXT] Re: [PATCH v1 net] page_pool: Cap queue size to 32k. On 14/08/2023 10.05, Ratheesh Kannoth wrote: >> From: Johannes Berg <johannes@...solutions.net> >> Subject: [EXT] Re: [PATCH v1 net] page_pool: Cap queue size to 32k. >>> Please find discussion at >>> https://urldefense.proofpoint.com/v2/url?u=https-3A__lore.kernel.org_l >>> >> I'm not the one who's going to apply this, but honestly, I don't think that will >> work as a commit message for such a change ... >> Sure, link to it by all means, but also summarize it and make sense of it for >> the commit message? > > Why do you think it will not work ?. There is a long discussion about pros and cons of different approaches by > Page pool maintainers in the discussion link. However I summarize it here, as commit message, it will > Lead to some more questions by reviewers. > I agree with Johannes, this commit message is too thin. It makes sense to give a summary of the discussion, because it show us (page_pool maintainers) what you concluded for the discussion. Further more, you also send another patch: - "[PATCH net-next] page_pool: Set page pool size" - https://lore.kernel.org/all/20230809021920.913324-1-rkannoth@marvell.com/ That patch solves the issue for your driver marvell/octeontx2 and I like than change. Why did you conclude that PP core should also change? --Jesper (p.s. Cc/To list have gotten excessive with 89 recipients)
Powered by blists - more mailing lists