netdev - Re: [PATCH net-next] selftests: bonding: remove redundant delete action of device link1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZNxorHjkyjktoj9m@Laptop-X1>
Date: Wed, 16 Aug 2023 14:11:56 +0800
From: Hangbin Liu <liuhangbin@...il.com>
To: Zhengchao Shao <shaozhengchao@...wei.com>
Cc: netdev@...r.kernel.org, linux-kselftest@...r.kernel.org,
	shuah@...nel.org, j.vosburgh@...il.com, andy@...yhouse.net,
	weiyongjun1@...wei.com, yuehaibing@...wei.com
Subject: Re: [PATCH net-next] selftests: bonding: remove redundant delete
 action of device link1_1

On Sat, Aug 12, 2023 at 04:40:36PM +0800, Zhengchao Shao wrote:
> When run command "ip netns delete client", device link1_1 has been
> deleted. So, it is no need to delete link1_1 again. Remove it.

What if the test exit because the cmd execute failed before setting
link1_1 to netns client?

Thanks
Hangbin
> 
> Signed-off-by: Zhengchao Shao <shaozhengchao@...wei.com>
> ---
>  .../drivers/net/bonding/bond-arp-interval-causes-panic.sh        | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/drivers/net/bonding/bond-arp-interval-causes-panic.sh b/tools/testing/selftests/drivers/net/bonding/bond-arp-interval-causes-panic.sh
> index 71c00bfafbc9..7b2d421f09cf 100755
> --- a/tools/testing/selftests/drivers/net/bonding/bond-arp-interval-causes-panic.sh
> +++ b/tools/testing/selftests/drivers/net/bonding/bond-arp-interval-causes-panic.sh
> @@ -11,7 +11,6 @@ finish()
>  {
>  	ip netns delete server || true
>  	ip netns delete client || true
> -	ip link del link1_1 || true
>  }
>  
>  trap finish EXIT
> -- 
> 2.34.1
>