netdev - Re: [RFC net-next 01/13] net: page_pool: split the page_pool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <85d5067b-6515-5a0a-e70d-b40c5d352892@kernel.org>
Date: Thu, 17 Aug 2023 11:31:28 +0200
From: Jesper Dangaard Brouer <hawk@...nel.org>
To: Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org
Cc: hawk@...nel.org, ilias.apalodimas@...aro.org,
 aleksander.lobakin@...el.com, linyunsheng@...wei.com, almasrymina@...gle.com
Subject: Re: [RFC net-next 01/13] net: page_pool: split the page_pool_params
 into fast and slow



On 17/08/2023 01.42, Jakub Kicinski wrote:
> struct page_pool is rather performance critical and we use
> 16B of the first cache line to store 2 pointers used only
> by test code. Future patches will add more informational
> (non-fast path) attributes.
> 
> It's convenient for the user of the API to not have to worry
> which fields are fast and which are slow path. Use struct
> groups to split the params into the two categories internally.
> 
> Signed-off-by: Jakub Kicinski<kuba@...nel.org>
> ---
>   include/net/page_pool/types.h | 31 +++++++++++++++++++------------
>   net/core/page_pool.c          |  7 ++++---
>   2 files changed, 23 insertions(+), 15 deletions(-)

With changes in 2/13 where you add a bool to avoid accessing "slow":

Acked-by: Jesper Dangaard Brouer <hawk@...nel.org>