lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <b1887aa8-3327-497a-bd23-680b533f6356@lunn.ch> Date: Thu, 17 Aug 2023 14:28:51 +0200 From: Andrew Lunn <andrew@...n.ch> To: Ruan Jinjie <ruanjinjie@...wei.com> Cc: Shyam-sundar.S-k@....com, davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com, yisen.zhuang@...wei.com, salil.mehta@...wei.com, iyappan@...amperecomputing.com, keyur@...amperecomputing.com, quan@...amperecomputing.com, hkallweit1@...il.com, linux@...linux.org.uk, yankejian@...wei.com, netdev@...r.kernel.org Subject: Re: [PATCH net-next 2/3] amd-xgbe: Return proper error code for get_phy_device() On Thu, Aug 17, 2023 at 03:39:59PM +0800, Ruan Jinjie wrote: > get_phy_device() returns -EIO on bus access error and -ENOMEM > on kzalloc failure in addition to -ENODEV, just return -ENODEV is not > sensible, use PTR_ERR(phydev) to fix the issue. Rather than say 'not sensible', it would be better to say 'Best practice is to return these error codes'. Reviewed-by: Andrew Lunn <andrew@...n.ch> Andrew --- pw-bot: cr
Powered by blists - more mailing lists