netdev - Re: [PATCH net-next 3/3] net: hisilicon: hns: Fix return value check for get_phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6e5445ad-22bb-4e35-9333-3a1de800113d@lunn.ch>
Date: Thu, 17 Aug 2023 14:29:32 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Ruan Jinjie <ruanjinjie@...wei.com>
Cc: Shyam-sundar.S-k@....com, davem@...emloft.net, edumazet@...gle.com,
	kuba@...nel.org, pabeni@...hat.com, yisen.zhuang@...wei.com,
	salil.mehta@...wei.com, iyappan@...amperecomputing.com,
	keyur@...amperecomputing.com, quan@...amperecomputing.com,
	hkallweit1@...il.com, linux@...linux.org.uk, yankejian@...wei.com,
	netdev@...r.kernel.org
Subject: Re: [PATCH net-next 3/3] net: hisilicon: hns: Fix return value check
 for get_phy_device()

On Thu, Aug 17, 2023 at 03:40:00PM +0800, Ruan Jinjie wrote:
> The get_phy_device() function returns error pointers and never
> returns NULL. Update the checks accordingly.
> 
> Fixes: 1d1afa2ebf82 ("net: hns: register phy device in each mac initial sequence")
> Signed-off-by: Ruan Jinjie <ruanjinjie@...wei.com>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew