lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20230817171104.GW22185@unreal> Date: Thu, 17 Aug 2023 20:11:04 +0300 From: Leon Romanovsky <leon@...nel.org> To: Tony Nguyen <anthony.l.nguyen@...el.com> Cc: davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com, edumazet@...gle.com, netdev@...r.kernel.org, Przemek Kitszel <przemyslaw.kitszel@...el.com>, Jacob Keller <jacob.e.keller@...el.com>, Simon Horman <horms@...nel.org>, Pucha Himasekhar Reddy <himasekharx.reddy.pucha@...el.com> Subject: Re: [PATCH net-next 14/14] ice: split ice_aq_wait_for_event() func into two On Wed, Aug 16, 2023 at 01:47:36PM -0700, Tony Nguyen wrote: > From: Przemek Kitszel <przemyslaw.kitszel@...el.com> > > Mitigate race between registering on wait list and receiving > AQ Response from FW. > > ice_aq_prep_for_event() should be called before sending AQ command, > ice_aq_wait_for_event() should be called after sending AQ command, > to wait for AQ Response. > > Please note, that this was found by reading the code, > an actual race has not yet materialized. > > Reviewed-by: Jacob Keller <jacob.e.keller@...el.com> > Signed-off-by: Przemek Kitszel <przemyslaw.kitszel@...el.com> > Reviewed-by: Simon Horman <horms@...nel.org> > Tested-by: Pucha Himasekhar Reddy <himasekharx.reddy.pucha@...el.com> (A Contingent worker at Intel) > Signed-off-by: Tony Nguyen <anthony.l.nguyen@...el.com> > --- > drivers/net/ethernet/intel/ice/ice.h | 5 +- > .../net/ethernet/intel/ice/ice_fw_update.c | 13 ++-- > drivers/net/ethernet/intel/ice/ice_main.c | 67 ++++++++++++------- > 3 files changed, 57 insertions(+), 28 deletions(-) > Thanks, Reviewed-by: Leon Romanovsky <leonro@...dia.com>
Powered by blists - more mailing lists