netdev - Re: [PATCH net-next 04/14] ice: refactor ice_vf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6fe694f8-9e5f-f1cb-848a-64ae11b324d9@intel.com>
Date: Thu, 17 Aug 2023 14:04:49 -0700
From: Tony Nguyen <anthony.l.nguyen@...el.com>
To: Leon Romanovsky <leon@...nel.org>
CC: <davem@...emloft.net>, <kuba@...nel.org>, <pabeni@...hat.com>,
	<edumazet@...gle.com>, <netdev@...r.kernel.org>, Jan Sokolowski
	<jan.sokolowski@...el.com>, Jacob Keller <jacob.e.keller@...el.com>, "Przemek
 Kitszel" <przemyslaw.kitszel@...el.com>
Subject: Re: [PATCH net-next 04/14] ice: refactor ice_vf_lib to make functions
 static

On 8/17/2023 4:34 AM, Leon Romanovsky wrote:

...

>> +/**
>> + * ice_vf_set_host_trust_cfg - set trust setting based on pre-reset value
>> + * @vf: VF to configure trust setting for
>> + */
>> +static void ice_vf_set_host_trust_cfg(struct ice_vf *vf)
>> +{
>> +	if (vf->trusted)
>> +		set_bit(ICE_VIRTCHNL_VF_CAP_PRIVILEGE, &vf->vf_caps);
>> +	else
>> +		clear_bit(ICE_VIRTCHNL_VF_CAP_PRIVILEGE, &vf->vf_caps);
>> +}
> 
> assign_bit(ICE_VIRTCHNL_VF_CAP_PRIVILEGE, &vf->vf_caps, vf->trusted);

Thanks for the review Leon. I'll add this change on as an additional 
patch into this series so that this one can stick to being static and 
reorders only.

-Tony