netdev - Re: [PATCH net-next] stmmac: intel: Enable correction of MAC propagation delay

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d3f8f803-e658-2cf6-544a-2305a09a1a97@pengutronix.de>
Date: Fri, 18 Aug 2023 14:16:31 +0200
From: Johannes Zink <j.zink@...gutronix.de>
To: Kurt Kanzenbach <kurt@...utronix.de>,
 Alexandre Torgue <alexandre.torgue@...s.st.com>,
 Jose Abreu <joabreu@...opsys.com>
Cc: "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>, Maxime Coquelin
 <mcoquelin.stm32@...il.com>, netdev@...r.kernel.org,
 Richard Cochran <richardcochran@...il.com>
Subject: Re: [PATCH net-next] stmmac: intel: Enable correction of MAC
 propagation delay

On 8/18/23 13:14, Kurt Kanzenbach wrote:
> All captured timestamps should be corrected by PHY, MAC and CDC introduced
> latency/errors. The CDC correction is already used. Enable MAC propagation delay
> correction as well which is available since commit 26cfb838aa00 ("net: stmmac:
> correct MAC propagation delay").
> 
> Before:
> |ptp4l[390.458]: rms    7 max   21 freq   +177 +/-  14 delay   357 +/-   1
> 
> After:
> |ptp4l[620.012]: rms    7 max   20 freq   +195 +/-  14 delay   345 +/-   1
> 
> Tested on Intel Elkhart Lake.
> 
> Signed-off-by: Kurt Kanzenbach <kurt@...utronix.de>

LGTM

feel free to add my

Reviewed-by: Johannes Zink <j.zink@...gutronix.de>

> ---
>   drivers/net/ethernet/stmicro/stmmac/dwmac-intel.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-intel.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-intel.c
> index 979c755964b1..a3a249c63598 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-intel.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-intel.c
> @@ -627,6 +627,7 @@ static int ehl_common_data(struct pci_dev *pdev,
>   	plat->rx_queues_to_use = 8;
>   	plat->tx_queues_to_use = 8;
>   	plat->flags |= STMMAC_FLAG_USE_PHY_WOL;
> +	plat->flags |= STMMAC_FLAG_HWTSTAMP_CORRECT_LATENCY;
>   
>   	plat->safety_feat_cfg->tsoee = 1;
>   	plat->safety_feat_cfg->mrxpee = 1;

-- 
Pengutronix e.K.                | Johannes Zink                  |
Steuerwalder Str. 21            | https://www.pengutronix.de/    |
31137 Hildesheim, Germany       | Phone: +49-5121-206917-0       |
Amtsgericht Hildesheim, HRA 2686| Fax:   +49-5121-206917-5555    |