[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ad5dd02a-f84d-0b7b-bd82-1e71141e06ef@linux.vnet.ibm.com>
Date: Fri, 18 Aug 2023 08:24:51 -0500
From: Thinh Tran <thinhtr@...ux.vnet.ibm.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: aelior@...vell.com, davem@...emloft.net, edumazet@...gle.com,
manishc@...vell.com, netdev@...r.kernel.org, pabeni@...hat.com,
skalluru@...vell.com, VENKATA.SAI.DUGGI@....com,
Abdul Haleem <abdhalee@...ibm.com>,
David Christensen <drc@...ux.vnet.ibm.com>,
Simon Horman <simon.horman@...igine.com>
Subject: Re: [Patch v5 0/4] bnx2x: Fix error recovering in switch
configuration
On 8/11/2023 5:09 PM, Jakub Kicinski wrote:
>
> It's looking fairly reasonable, thanks!
>
> We do need commit messages describing motivations and impact
> of each individual commit, tho, and those commits which are
> not refactoring / improvements but prevent crashes need to
> have a Fixes tag pointing to the first commit in history where
> problem may occur (sometimes it's the first commit of the entire
> history).
Thanks the review. I'll make the correction and resubmit them shortly.
Thinh Tran
Powered by blists - more mailing lists