netdev - Re: [Patch v5 2/4] bnx2x: factor out common code to bnx2x_stop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230811150826.454b63dd@kernel.org>
Date: Fri, 11 Aug 2023 15:08:26 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Thinh Tran <thinhtr@...ux.vnet.ibm.com>
Cc: aelior@...vell.com, davem@...emloft.net, edumazet@...gle.com,
 manishc@...vell.com, netdev@...r.kernel.org, pabeni@...hat.com,
 skalluru@...vell.com, VENKATA.SAI.DUGGI@....com
Subject: Re: [Patch v5 2/4] bnx2x: factor out common code to
 bnx2x_stop_nic()

On Fri, 11 Aug 2023 15:15:10 -0500 Thinh Tran wrote:
>  }
> +void bnx2x_stop_nic(struct bnx2x *bp, int disable_hw)
> +{

nit: empty line between closing bracket of previous function and the
beginning of the new one, please (checkpatch --strict should hopefully
point that out, although I haven't confirmed).