netdev - Re: [PATCH vfio] pds_core: Fix function header descriptions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 18 Aug 2023 09:17:05 -0600
From: Alex Williamson <alex.williamson@...hat.com>
To: Brett Creeley <brett.creeley@....com>
Cc: <kvm@...r.kernel.org>, <netdev@...r.kernel.org>, <jgg@...dia.com>,
 <shameerali.kolothum.thodi@...wei.com>, <kevin.tian@...el.com>,
 <shannon.nelson@....com>
Subject: Re: [PATCH vfio] pds_core: Fix function header descriptions

On Thu, 17 Aug 2023 15:42:12 -0700
Brett Creeley <brett.creeley@....com> wrote:

> The pds-vfio-pci series made a small interface change to
> pds_client_register() and pds_client_unregister(), but forgot to update
> the function header descriptions. Fix that.
> 
> Reported-by: kernel test robot <lkp@...el.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202308180411.OSqJPtMz-lkp@intel.com/
> Signed-off-by: Shannon Nelson <shannon.nelson@....com>
> Signed-off-by: Brett Creeley <brett.creeley@....com>

I think we also want:

Fixes: b021d05e106e ("pds_core: Require callers of register/unregister to pass PF drvdata")

I'll add that on commit.  Thanks,

Alex

> ---
>  drivers/net/ethernet/amd/pds_core/auxbus.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/amd/pds_core/auxbus.c b/drivers/net/ethernet/amd/pds_core/auxbus.c
> index 63d28c0a7e08..4ebc8ad87b41 100644
> --- a/drivers/net/ethernet/amd/pds_core/auxbus.c
> +++ b/drivers/net/ethernet/amd/pds_core/auxbus.c
> @@ -8,7 +8,7 @@
>  
>  /**
>   * pds_client_register - Link the client to the firmware
> - * @pf_pdev:	ptr to the PF driver struct
> + * @pf:		ptr to the PF driver's private data struct
>   * @devname:	name that includes service into, e.g. pds_core.vDPA
>   *
>   * Return: 0 on success, or
> @@ -48,7 +48,7 @@ EXPORT_SYMBOL_GPL(pds_client_register);
>  
>  /**
>   * pds_client_unregister - Unlink the client from the firmware
> - * @pf_pdev:	ptr to the PF driver struct
> + * @pf:		ptr to the PF driver's private data struct
>   * @client_id:	id returned from pds_client_register()
>   *
>   * Return: 0 on success, or