netdev - Re: [PATCH net-next] selftests: vrf_route_leaking: remove ipv6_ping

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <78721609-ced2-9cb7-a0d3-d4e1d90494a7@kernel.org>
Date: Fri, 18 Aug 2023 09:18:13 -0600
From: David Ahern <dsahern@...nel.org>
To: Hangbin Liu <liuhangbin@...il.com>, netdev@...r.kernel.org
Cc: "David S . Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>, Ido Schimmel <idosch@...sch.org>,
 Michael Jeanson <mjeanson@...icios.com>
Subject: Re: [PATCH net-next] selftests: vrf_route_leaking: remove
 ipv6_ping_frag from default testing

On 8/18/23 2:06 AM, Hangbin Liu wrote:
> As the initial commit 1a01727676a8 ("selftests: Add VRF route leaking
> tests") said, the IPv6 MTU test fails as source address selection
> picking ::1. Every time we run the selftest this one report failed.
> There seems not much meaning  to keep reporting a failure for 3 years
> that no one plan to fix/update. Let't just skip this one first. We can
> add it back when the issue fixed.
> 
> Signed-off-by: Hangbin Liu <liuhangbin@...il.com>
> ---
>  tools/testing/selftests/net/vrf_route_leaking.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/net/vrf_route_leaking.sh b/tools/testing/selftests/net/vrf_route_leaking.sh
> index 23cf924754a5..dedc52562b4f 100755
> --- a/tools/testing/selftests/net/vrf_route_leaking.sh
> +++ b/tools/testing/selftests/net/vrf_route_leaking.sh
> @@ -565,7 +565,7 @@ EOF
>  command -v ping6 > /dev/null 2>&1 && ping6=$(command -v ping6) || ping6=$(command -v ping)
>  
>  TESTS_IPV4="ipv4_ping_ttl ipv4_traceroute ipv4_ping_frag ipv4_ping_ttl_asym ipv4_traceroute_asym"
> -TESTS_IPV6="ipv6_ping_ttl ipv6_traceroute ipv6_ping_frag ipv6_ping_ttl_asym ipv6_traceroute_asym"
> +TESTS_IPV6="ipv6_ping_ttl ipv6_traceroute ipv6_ping_ttl_asym ipv6_traceroute_asym"
>  
>  ret=0
>  nsuccess=0

Needs to be fixed, but clearly not a high priority. I am ok with
disabling the failed test:

Reviewed-by: David Ahern <dsahern@...nel.org>