netdev - Re: [PATCH net-next v5 15/15] idpf: configure SRIOV and add other ndo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e40bd282-9d88-c182-f2ab-dce9bd3f5f7e@intel.com>
Date: Fri, 18 Aug 2023 10:41:46 -0700
From: "Linga, Pavan Kumar" <pavan.kumar.linga@...el.com>
To: Jakub Kicinski <kuba@...nel.org>, Tony Nguyen <anthony.l.nguyen@...el.com>
CC: <davem@...emloft.net>, <pabeni@...hat.com>, <edumazet@...gle.com>,
	<netdev@...r.kernel.org>, Joshua Hay <joshua.a.hay@...el.com>,
	<emil.s.tantilov@...el.com>, <jesse.brandeburg@...el.com>,
	<sridhar.samudrala@...el.com>, <shiraz.saleem@...el.com>,
	<sindhu.devale@...el.com>, <willemb@...gle.com>, <decot@...gle.com>,
	<andrew@...n.ch>, <leon@...nel.org>, <mst@...hat.com>,
	<simon.horman@...igine.com>, <shannon.nelson@....com>,
	<stephen@...workplumber.org>, <corbet@....net>, <linux-doc@...r.kernel.org>,
	Alan Brady <alan.brady@...el.com>, Madhu Chittim <madhu.chittim@...el.com>,
	Phani Burra <phani.r.burra@...el.com>
Subject: Re: [PATCH net-next v5 15/15] idpf: configure SRIOV and add other
 ndo_ops



On 8/17/2023 8:02 PM, Jakub Kicinski wrote:
> On Tue, 15 Aug 2023 17:43:05 -0700 Tony Nguyen wrote:
>> Add PCI callback to configure SRIOV and add the necessary support
>> to initialize the requested number of VFs by sending the virtchnl
>> message to the device Control Plane.
> 
> There is no API here to configure the SRIOV, please drop that from
> the next verison.
> 

Make sense. Will reword the commit message accordingly.

> Sorry I run out of day. My comments so far are pretty minor, feel
> free to post v6 without waiting the 24h, otherwise I'll take a look
> at 9-14 tomorrow.
> 
> Please add my Acked-by on patches 1-7, if you're posting v6.