netdev - Re: [PATCH net-next v5 08/15] idpf: configure resources for RX queues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <566d4192-d486-bfc2-59ef-e9f87f290c4b@intel.com>
Date: Fri, 18 Aug 2023 10:36:48 -0700
From: "Linga, Pavan Kumar" <pavan.kumar.linga@...el.com>
To: Jakub Kicinski <kuba@...nel.org>, Tony Nguyen <anthony.l.nguyen@...el.com>
CC: <davem@...emloft.net>, <pabeni@...hat.com>, <edumazet@...gle.com>,
	<netdev@...r.kernel.org>, Alan Brady <alan.brady@...el.com>,
	<emil.s.tantilov@...el.com>, <jesse.brandeburg@...el.com>,
	<sridhar.samudrala@...el.com>, <shiraz.saleem@...el.com>,
	<sindhu.devale@...el.com>, <willemb@...gle.com>, <decot@...gle.com>,
	<andrew@...n.ch>, <leon@...nel.org>, <mst@...hat.com>,
	<simon.horman@...igine.com>, <shannon.nelson@....com>,
	<stephen@...workplumber.org>, Alice Michael <alice.michael@...el.com>, Joshua
 Hay <joshua.a.hay@...el.com>, Madhu Chittim <madhu.chittim@...el.com>, Phani
 Burra <phani.r.burra@...el.com>
Subject: Re: [PATCH net-next v5 08/15] idpf: configure resources for RX queues



On 8/17/2023 7:58 PM, Jakub Kicinski wrote:
> On Tue, 15 Aug 2023 17:42:58 -0700 Tony Nguyen wrote:
>> +	page_pool_put_page(rxq->pp, rx_buf->page, rx_buf->truesize, false);
> 
> I think the truesize here is incorrect, there's new documentation
> for this very case:
> 
> https://docs.kernel.org/next/networking/page_pool.html#dma-sync

Thanks for the review. Will fix in the next revision.

Regards,
Pavan