netdev - Re: [PATCH net-next v5 10/15] idpf: add splitq start

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230818113740.1ed88d8a@kernel.org>
Date: Fri, 18 Aug 2023 11:37:40 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Tony Nguyen <anthony.l.nguyen@...el.com>
Cc: davem@...emloft.net, pabeni@...hat.com, edumazet@...gle.com,
 netdev@...r.kernel.org, Joshua Hay <joshua.a.hay@...el.com>,
 pavan.kumar.linga@...el.com, emil.s.tantilov@...el.com,
 jesse.brandeburg@...el.com, sridhar.samudrala@...el.com,
 shiraz.saleem@...el.com, sindhu.devale@...el.com, willemb@...gle.com,
 decot@...gle.com, andrew@...n.ch, leon@...nel.org, mst@...hat.com,
 simon.horman@...igine.com, shannon.nelson@....com,
 stephen@...workplumber.org, Alan Brady <alan.brady@...el.com>, Madhu
 Chittim <madhu.chittim@...el.com>, Phani Burra <phani.r.burra@...el.com>
Subject: Re: [PATCH net-next v5 10/15] idpf: add splitq start_xmit

On Tue, 15 Aug 2023 17:43:00 -0700 Tony Nguyen wrote:
> +	netif_stop_subqueue(tx_q->vport->netdev, tx_q->idx);
> +
> +	/* Memory barrier before checking head and tail */
> +	smp_mb();
> +
> +	/* Check again in a case another CPU has just made room available. */
> +	if (likely(IDPF_DESC_UNUSED(tx_q) < size))
> +		return -EBUSY;
> +
> +	/* A reprieve! - use start_subqueue because it doesn't call schedule */
> +	netif_start_subqueue(tx_q->vport->netdev, tx_q->idx);

Please use the helpers from include/net/netdev_queues.h.