netdev - Re: [PATCH iproute2-next] utils: fix get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ca7f140f-1717-456f-0385-c3d2ff71f95c@schroetersa.ch>
Date: Sun, 20 Aug 2023 22:07:40 +0200
From: Mathieu Schroeter <mathieu@...roetersa.ch>
To: Pedro Tammela <pctammela@...atatu.com>, netdev@...r.kernel.org
Cc: stephen@...workplumber.org, dsahern@...il.com
Subject: Re: [PATCH iproute2-next] utils: fix get_integer() logic

Le 19.08.23 à 22:54, Pedro Tammela a écrit :
> After 3a463c15, get_integer() doesn't return the converted value and
> always writes 0 in 'val' in case of success.
> Fix the logic so it writes the converted value in 'val'.
>
> Fixes: 3a463c15 ("Add get_long utility and adapt get_integer accordingly"
> Signed-off-by: Pedro Tammela <pctammela@...atatu.com>
> ---
>   lib/utils.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/lib/utils.c b/lib/utils.c
> index efa01668..99ba7a23 100644
> --- a/lib/utils.c
> +++ b/lib/utils.c
> @@ -142,7 +142,8 @@ int get_integer(int *val, const char *arg, int base)
>   {
>   	long res;
>   
> -	res = get_long(NULL, arg, base);
> +	if (get_long(&res, arg, base) < 0)
> +		return -1;
>   
>   	/* Outside range of int */
>   	if (res < INT_MIN || res > INT_MAX)

my bad

Thank you !


Download attachment "OpenPGP_signature" of type "application/pgp-signature" (496 bytes)