lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <69e9c563-2f07-4e9e-b43a-145839fe2afd@amd.com> Date: Mon, 21 Aug 2023 12:40:16 -0700 From: "Nelson, Shannon" <shannon.nelson@....com> To: netdev@...r.kernel.org Subject: Re: [PATCH net-next] ionic: Remove unused declarations On 8/21/2023 10:26 AM, Nelson, Shannon wrote: > On 8/21/2023 6:47 AM, Yue Haibing wrote: >> >> Commit fbfb8031533c ("ionic: Add hardware init and device commands") >> declared but never implemented ionic_q_rewind()/ionic_set_dma_mask(). >> Commit 969f84394604 ("ionic: sync the filters in the work task") >> declared but never implemented ionic_rx_filters_need_sync(). >> >> Signed-off-by: Yue Haibing <yuehaibing@...wei.com> > > This should include a "Fixes" tag > sln Let's see if I can make the magic work... pw-bot: changes-requested > >> --- >> drivers/net/ethernet/pensando/ionic/ionic.h | 1 - >> drivers/net/ethernet/pensando/ionic/ionic_dev.h | 1 - >> drivers/net/ethernet/pensando/ionic/ionic_rx_filter.h | 1 - >> 3 files changed, 3 deletions(-) >> >> diff --git a/drivers/net/ethernet/pensando/ionic/ionic.h >> b/drivers/net/ethernet/pensando/ionic/ionic.h >> index 602f4d45d529..2453a40f6ee8 100644 >> --- a/drivers/net/ethernet/pensando/ionic/ionic.h >> +++ b/drivers/net/ethernet/pensando/ionic/ionic.h >> @@ -81,7 +81,6 @@ int ionic_dev_cmd_wait(struct ionic *ionic, unsigned >> long max_wait); >> int ionic_dev_cmd_wait_nomsg(struct ionic *ionic, unsigned long >> max_wait); >> void ionic_dev_cmd_dev_err_print(struct ionic *ionic, u8 opcode, u8 >> status, >> int err); >> -int ionic_set_dma_mask(struct ionic *ionic); >> int ionic_setup(struct ionic *ionic); >> >> int ionic_identify(struct ionic *ionic); >> diff --git a/drivers/net/ethernet/pensando/ionic/ionic_dev.h >> b/drivers/net/ethernet/pensando/ionic/ionic_dev.h >> index 0bea208bfba2..6aac98bcb9f4 100644 >> --- a/drivers/net/ethernet/pensando/ionic/ionic_dev.h >> +++ b/drivers/net/ethernet/pensando/ionic/ionic_dev.h >> @@ -376,7 +376,6 @@ void ionic_q_cmb_map(struct ionic_queue *q, void >> __iomem *base, dma_addr_t base_ >> void ionic_q_sg_map(struct ionic_queue *q, void *base, dma_addr_t >> base_pa); >> void ionic_q_post(struct ionic_queue *q, bool ring_doorbell, >> ionic_desc_cb cb, >> void *cb_arg); >> -void ionic_q_rewind(struct ionic_queue *q, struct ionic_desc_info >> *start); >> void ionic_q_service(struct ionic_queue *q, struct ionic_cq_info >> *cq_info, >> unsigned int stop_index); >> int ionic_heartbeat_check(struct ionic *ionic); >> diff --git a/drivers/net/ethernet/pensando/ionic/ionic_rx_filter.h >> b/drivers/net/ethernet/pensando/ionic/ionic_rx_filter.h >> index 87b2666f248b..ee9e99cd1b5e 100644 >> --- a/drivers/net/ethernet/pensando/ionic/ionic_rx_filter.h >> +++ b/drivers/net/ethernet/pensando/ionic/ionic_rx_filter.h >> @@ -43,7 +43,6 @@ struct ionic_rx_filter >> *ionic_rx_filter_by_addr(struct ionic_lif *lif, const u8 >> struct ionic_rx_filter *ionic_rx_filter_rxsteer(struct ionic_lif *lif); >> void ionic_rx_filter_sync(struct ionic_lif *lif); >> int ionic_lif_list_addr(struct ionic_lif *lif, const u8 *addr, bool >> mode); >> -int ionic_rx_filters_need_sync(struct ionic_lif *lif); >> int ionic_lif_vlan_add(struct ionic_lif *lif, const u16 vid); >> int ionic_lif_vlan_del(struct ionic_lif *lif, const u16 vid); >> >> -- >> 2.34.1 >>
Powered by blists - more mailing lists