[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <b113a610-15b0-460a-a439-3e8461ae3f60@amd.com>
Date: Mon, 21 Aug 2023 12:42:52 -0700
From: "Nelson, Shannon" <shannon.nelson@....com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Yue Haibing <yuehaibing@...wei.com>, brett.creeley@....com,
drivers@...sando.io, davem@...emloft.net, pabeni@...hat.com,
netdev@...r.kernel.org
Subject: Re: [PATCH net-next] ionic: Remove unused declarations
On 8/21/2023 12:39 PM, Jakub Kicinski wrote:
>
> On Mon, 21 Aug 2023 10:26:40 -0700 Nelson, Shannon wrote:
>>> Commit fbfb8031533c ("ionic: Add hardware init and device commands")
>>> declared but never implemented ionic_q_rewind()/ionic_set_dma_mask().
>>> Commit 969f84394604 ("ionic: sync the filters in the work task")
>>> declared but never implemented ionic_rx_filters_need_sync().
>>>
>>> Signed-off-by: Yue Haibing <yuehaibing@...wei.com>
>>
>> This should include a "Fixes" tag
>
> Nope, it's harmless, no Fixes needed.
> Fixes is for backporting, why would we backport this.
Okay.
Unfortunately I experimented with sending the "changes requested"
message to the pw bot just before receiving your note...
sln
Powered by blists - more mailing lists