netdev - Re: [PATCH net-next] ionic: Remove unused declarations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 21 Aug 2023 13:05:12 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: "Nelson, Shannon" <shannon.nelson@....com>
Cc: Yue Haibing <yuehaibing@...wei.com>, brett.creeley@....com,
 drivers@...sando.io, davem@...emloft.net, pabeni@...hat.com,
 netdev@...r.kernel.org
Subject: Re: [PATCH net-next] ionic: Remove unused declarations

On Mon, 21 Aug 2023 12:42:52 -0700 Nelson, Shannon wrote:
> > Nope, it's harmless, no Fixes needed.
> > Fixes is for backporting, why would we backport this.  
> 
> Okay.
> 
> Unfortunately I experimented with sending the "changes requested" 
> message to the pw bot just before receiving your note...

As luck would have it - seems like something in the copious Outlook
headers confuses python's email library:

$ wget https://lore.kernel.org/all/69e9c563-2f07-4e9e-b43a-145839fe2afd@amd.com/raw
$ python
>>> import email
>>> from email.policy import default
>>> with open('raw', 'rb') as fp:
...   raw = fp.read()
...   msg = email.message_from_bytes(raw, policy=default)
...
>>> msg.get_body(preferencelist=('plain',)).as_string().split('\n')[-1]
''
>>> msg.get_body(preferencelist=('plain',)).as_string().split('\n')[0]
'Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net'


It thinks the headers are the body, so we missed the pw-bot command.