netdev - Re: [PATCH net] rtnetlink: Reject negative ifindexes in RTM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Thu, 24 Aug 2023 08:00:23 +0000
From: patchwork-bot+netdevbpf@...nel.org
To: Ido Schimmel <idosch@...dia.com>
Cc: netdev@...r.kernel.org, davem@...emloft.net, kuba@...nel.org,
 pabeni@...hat.com, edumazet@...gle.com, razor@...ckwall.org, jiri@...dia.com,
 mlxsw@...dia.com
Subject: Re: [PATCH net] rtnetlink: Reject negative ifindexes in RTM_NEWLINK

Hello:

This patch was applied to netdev/net.git (main)
by Paolo Abeni <pabeni@...hat.com>:

On Wed, 23 Aug 2023 09:43:48 +0300 you wrote:
> Negative ifindexes are illegal, but the kernel does not validate the
> ifindex in the ancillary header of RTM_NEWLINK messages, resulting in
> the kernel generating a warning [1] when such an ifindex is specified.
> 
> Fix by rejecting negative ifindexes.
> 
> [1]
> WARNING: CPU: 0 PID: 5031 at net/core/dev.c:9593 dev_index_reserve+0x1a2/0x1c0 net/core/dev.c:9593
> [...]
> Call Trace:
>  <TASK>
>  register_netdevice+0x69a/0x1490 net/core/dev.c:10081
>  br_dev_newlink+0x27/0x110 net/bridge/br_netlink.c:1552
>  rtnl_newlink_create net/core/rtnetlink.c:3471 [inline]
>  __rtnl_newlink+0x115e/0x18c0 net/core/rtnetlink.c:3688
>  rtnl_newlink+0x67/0xa0 net/core/rtnetlink.c:3701
>  rtnetlink_rcv_msg+0x439/0xd30 net/core/rtnetlink.c:6427
>  netlink_rcv_skb+0x16b/0x440 net/netlink/af_netlink.c:2545
>  netlink_unicast_kernel net/netlink/af_netlink.c:1342 [inline]
>  netlink_unicast+0x536/0x810 net/netlink/af_netlink.c:1368
>  netlink_sendmsg+0x93c/0xe40 net/netlink/af_netlink.c:1910
>  sock_sendmsg_nosec net/socket.c:728 [inline]
>  sock_sendmsg+0xd9/0x180 net/socket.c:751
>  ____sys_sendmsg+0x6ac/0x940 net/socket.c:2538
>  ___sys_sendmsg+0x135/0x1d0 net/socket.c:2592
>  __sys_sendmsg+0x117/0x1e0 net/socket.c:2621
>  do_syscall_x64 arch/x86/entry/common.c:50 [inline]
>  do_syscall_64+0x38/0xb0 arch/x86/entry/common.c:80
>  entry_SYSCALL_64_after_hwframe+0x63/0xcd
> 
> [...]

Here is the summary with links:
  - [net] rtnetlink: Reject negative ifindexes in RTM_NEWLINK
    https://git.kernel.org/netdev/net/c/30188bd7838c

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html